Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2455

support pre-installed java environment

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: deployment
    • Labels:
      None

      Description

      Ignore jdk_package_name if a user indicates they have a pre-installed java environment.

      Some users may want a version of java that is not available (or not required) for puppet to install via the normal 'jdk_package_name' mechanism. For example, special architectures or custom/optimized java environments for which there is no jdk package to install.

      It would be nice to expose a 'jdk_preinstalled' configuration option that would turn the jdk_package_name handler into a no-op for these users.

      1. BIGTOP-2455.patch
        2 kB
        Kevin W Monroe

        Activity

        Hide
        kwmonroe Kevin W Monroe added a comment -

        With this patch, I am able to set the following in my site.yaml:

        'bigtop::jdk_preinstalled': True

        This causes puppet to ignore installation of the default 'jdk_package_name' package and use the java environment that is already available on my system.

        Show
        kwmonroe Kevin W Monroe added a comment - With this patch, I am able to set the following in my site.yaml: 'bigtop::jdk_preinstalled': True This causes puppet to ignore installation of the default 'jdk_package_name' package and use the java environment that is already available on my system.
        Hide
        cos Konstantin Boudnik added a comment -

        Looks good. However, I am not sure why this file bigtop-deploy/puppet/manifests/site.pp is in the patch? It doesn't seem like it is relevant to the patch, no?

        Show
        cos Konstantin Boudnik added a comment - Looks good. However, I am not sure why this file bigtop-deploy/puppet/manifests/site.pp is in the patch? It doesn't seem like it is relevant to the patch, no?
        Hide
        johnsca Cory Johns added a comment -

        The bigtop-deploy/puppet/manifests/site.pp portion, and in particular the noop is what makes it skip the installation of the JDK.

        Show
        johnsca Cory Johns added a comment - The bigtop-deploy/puppet/manifests/site.pp portion, and in particular the noop is what makes it skip the installation of the JDK.
        Hide
        cos Konstantin Boudnik added a comment -

        Oh, damn - I misread the patch. Yes, it looks good. I will commit it in a bit!

        Show
        cos Konstantin Boudnik added a comment - Oh, damn - I misread the patch. Yes, it looks good. I will commit it in a bit!
        Hide
        cos Konstantin Boudnik added a comment -

        Committed and pushed to the master. Thanks Kevin W Monroe!

        Show
        cos Konstantin Boudnik added a comment - Committed and pushed to the master. Thanks Kevin W Monroe !

          People

          • Assignee:
            kwmonroe Kevin W Monroe
            Reporter:
            kwmonroe Kevin W Monroe
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development