Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2423

Fix hard-coded port number in Sqoop smokes

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: tests
    • Labels:
      None

      Description

      Port number is hard-coded in TestSqoopETLHsql – should be looking for a system property and resorting to the default 9001 if none is provided.

      Also, needs substituting '9001' for the variable in a few lines.

      1. BIGTOP-2423.patch
        2 kB
        Dasha Boudnik

        Activity

        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        Patch attached.

        Show
        dasha.boudnik Dasha Boudnik added a comment - Patch attached.
        Hide
        cos Konstantin Boudnik added a comment -

        That seems to be quite sensible. Looks like the old code wasn't even accounting for the fact that the DB server could be started on a different port. LGTM!

        Show
        cos Konstantin Boudnik added a comment - That seems to be quite sensible. Looks like the old code wasn't even accounting for the fact that the DB server could be started on a different port. LGTM!
        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        Committed to master:
        c6033e96c255d482868f39f765d1f7384305d906

        Thanks!

        Show
        dasha.boudnik Dasha Boudnik added a comment - Committed to master: c6033e96c255d482868f39f765d1f7384305d906 Thanks!

          People

          • Assignee:
            dasha.boudnik Dasha Boudnik
            Reporter:
            dasha.boudnik Dasha Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development