Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2408

group_filter variable value is not templatize in puppet module of hue

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      LDAP section in hue.ini has an option to set group_filter as true and false but if we set it as true , we can't set its value. The default value is not templatize. If we can make it templatize then we can easily externalize this variable.

        Activity

        Hide
        oflebbe Olaf Flebbe added a comment -

        committed

        Show
        oflebbe Olaf Flebbe added a comment - committed
        Hide
        oflebbe Olaf Flebbe added a comment -

        Will take the commit from pull requests #102.
        LGTM +1.

        Show
        oflebbe Olaf Flebbe added a comment - Will take the commit from pull requests #102. LGTM +1.
        Hide
        amitkabraiiit Amit Kabra added a comment -

        Pull request contains commits for following jiras :
        BIGTOP-2407 : Making "force_username_lowercase" variable templatize in puppet module of hue
        BIGTOP-2408 : group_filter variable value is not templatize in puppet module of hue
        BIGTOP-2409 : nt_domain configuration option for hue to connect to Active Directory
        BIGTOP-2410 : Making "ldap_username_pattern" variable templatize in puppet module of hue

        Show
        amitkabraiiit Amit Kabra added a comment - Pull request contains commits for following jiras : BIGTOP-2407 : Making "force_username_lowercase" variable templatize in puppet module of hue BIGTOP-2408 : group_filter variable value is not templatize in puppet module of hue BIGTOP-2409 : nt_domain configuration option for hue to connect to Active Directory BIGTOP-2410 : Making "ldap_username_pattern" variable templatize in puppet module of hue
        Hide
        amitkabraiiit Amit Kabra added a comment -

        Okay,

        I fixed all the commit messages and all the commits are there in this pull request : https://github.com/apache/bigtop/pull/102/commits

        Show
        amitkabraiiit Amit Kabra added a comment - Okay, I fixed all the commit messages and all the commits are there in this pull request : https://github.com/apache/bigtop/pull/102/commits
        Hide
        oflebbe Olaf Flebbe added a comment - - edited

        BTW: It would be ok for me if you supply one github pull request with several commits (BIGTOP-2408 - BIGTOP-2410) in it, if each commit corresponds to one JIRA with proper commit message.

        Show
        oflebbe Olaf Flebbe added a comment - - edited BTW: It would be ok for me if you supply one github pull request with several commits ( BIGTOP-2408 - BIGTOP-2410 ) in it, if each commit corresponds to one JIRA with proper commit message.
        Hide
        oflebbe Olaf Flebbe added a comment -

        Could you please either :

        • Use github pull requests with the proper commit message (JIRA-NUMBER: JIRA Heading). One Pull request per JIRA
          or
        • Attach a git format-patch with the proper commit-message ?

        Additionaly: Could you please rebase this patch to current head ?

        I like to either merge a branch or use git am patchfile without adding the message an author by myself. This would make my work easier.

        Show
        oflebbe Olaf Flebbe added a comment - Could you please either : Use github pull requests with the proper commit message (JIRA-NUMBER: JIRA Heading). One Pull request per JIRA or Attach a git format-patch with the proper commit-message ? Additionaly: Could you please rebase this patch to current head ? I like to either merge a branch or use git am patchfile without adding the message an author by myself. This would make my work easier.
        Hide
        oflebbe Olaf Flebbe added a comment -

        LGTM: +1

        Show
        oflebbe Olaf Flebbe added a comment - LGTM: +1
        Hide
        amitkabraiiit Amit Kabra added a comment -
        Show
        amitkabraiiit Amit Kabra added a comment - Pull request : https://github.com/apache/bigtop/pull/102
        Hide
        amitkabraiiit Amit Kabra added a comment -

        Olaf Flebbe : Can you please review it and submit it ?

        Show
        amitkabraiiit Amit Kabra added a comment - Olaf Flebbe : Can you please review it and submit it ?

          People

          • Assignee:
            amitkabraiiit Amit Kabra
            Reporter:
            amitkabraiiit Amit Kabra
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development