Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2385

Reformat bigtop_toolchain/manifests/packages.pp to ease maintenance

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: toolchain
    • Labels:
      None

      Description

      Right now we have the packages listed as a single long string. Resolving conflicts coming from concurrent changes in the package lists is becoming increasingly difficult. Let's reformat these lists to look like

          /(?i:(SLES|opensuse))/: { $pkgs = [ 
      "unzip", 
      "curl", 
      "wget", 
      "git", 
      "make", 
      ....snipped....
      "libuuid-devel" ]
      

      Yes, the recipe file will look longer, but it will be a way easier to deal with the changes.

        Activity

        Hide
        oflebbe Olaf Flebbe added a comment -

        Commited. Thanks!

        Show
        oflebbe Olaf Flebbe added a comment - Commited. Thanks!
        Hide
        oflebbe Olaf Flebbe added a comment -

        +1, will commit it in a minute.

        Show
        oflebbe Olaf Flebbe added a comment - +1, will commit it in a minute.
        Hide
        sekikn Kengo Seki added a comment -

        Attaching a patch. Also fixed some indentions and whitespaces.

        Show
        sekikn Kengo Seki added a comment - Attaching a patch. Also fixed some indentions and whitespaces.

          People

          • Assignee:
            sekikn Kengo Seki
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development