Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2374

Toolchain needs clear warning for Puppet <3

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: toolchain
    • Labels:
      None

      Description

      Took me a while to figure out why puppet modules aren't getting installed. The reason is this silent fallback

          onlyif => "test `facter puppetversion |cut -d'.' -f 1` -ge 3",
      

      in the bigtop_toolchain/manifests/puppet-modules.pp

      We need to issue a clear warning instead of falling quietly - it is a bad UX.

        Activity

        Hide
        cos Konstantin Boudnik added a comment -

        Committed and pushed, thanks Kengo Seki

        Show
        cos Konstantin Boudnik added a comment - Committed and pushed, thanks Kengo Seki
        Hide
        cos Konstantin Boudnik added a comment -

        This is pretty cool! +1 Like it! Will commit in the morning. Thanks Kengo Seki!

        Show
        cos Konstantin Boudnik added a comment - This is pretty cool! +1 Like it! Will commit in the morning. Thanks Kengo Seki !
        Hide
        sekikn Kengo Seki added a comment -

        Attaching a pacth. Tested ./gradlew toolchain-puppetmodules fails on Puppet 2.7.26:

        [sekikn@localhost bigtop]$ facter puppetversion                                                                                                    
        2.7.26
        [sekikn@localhost bigtop]$ ./gradlew toolchain-puppetmodules
        
        (snip)
        
        bigtop_toolchain::puppet-modules requires Puppet 3.0.0+, but found: 2.7.26 at /home/sekikn/bigtop/bigtop_toolchain/manifests/puppet-modules-prereq.pp:19 on node localhost                                                                                                           
        :toolchain-puppetmodules FAILED                                                                                                            
                                                                                                                                                   
        FAILURE: Build failed with an exception.                                                                                                   
                                                                                                                                                   
        * What went wrong:                                                                                                                         
        Execution failed for task ':toolchain-puppetmodules'.                                                                                      
        > Process 'command 'sudo'' finished with non-zero exit value 1                                                                             
                                                                                                                                                   
        * Try:                                                                                                                                     
        Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.                             
                                                                                                                                                   
        BUILD FAILED                                                                                                                               
                                                                                                                                                   
        Total time: 10.713 secs                                                                                                                    
        

        and succeeds on 3.3.1:

        [sekikn@localhost bigtop]$ facter puppetversion                                                                                            
        3.3.1
        [sekikn@localhost bigtop]$ ./gradlew toolchain-puppetmodules
        
        (snip)
        
        BUILD SUCCESSFUL                                                                                                                           
                                                                                                                                                   
        Total time: 19.79 secs                                                                                                                     
                                                                                                                                                   
        This build could be faster, please consider using the Gradle Daemon: https://docs.gradle.org/2.7/userguide/gradle_daemon.html
        [sekikn@localhost bigtop]$ ls /etc/puppet/modules/stdlib                                                                                   
        CHANGELOG.md     examples  LICENSE        NOTICE                     README.markdown           spec
        checksums.json   Gemfile   manifests      Rakefile                   README_SPECS.markdown
        CONTRIBUTING.md  lib       metadata.json  README_DEVELOPER.markdown  RELEASE_PROCESS.markdown
        
        Show
        sekikn Kengo Seki added a comment - Attaching a pacth. Tested ./gradlew toolchain-puppetmodules fails on Puppet 2.7.26: [sekikn@localhost bigtop]$ facter puppetversion 2.7.26 [sekikn@localhost bigtop]$ ./gradlew toolchain-puppetmodules (snip) bigtop_toolchain::puppet-modules requires Puppet 3.0.0+, but found: 2.7.26 at /home/sekikn/bigtop/bigtop_toolchain/manifests/puppet-modules-prereq.pp:19 on node localhost :toolchain-puppetmodules FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':toolchain-puppetmodules'. > Process 'command 'sudo'' finished with non-zero exit value 1 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 10.713 secs and succeeds on 3.3.1: [sekikn@localhost bigtop]$ facter puppetversion 3.3.1 [sekikn@localhost bigtop]$ ./gradlew toolchain-puppetmodules (snip) BUILD SUCCESSFUL Total time: 19.79 secs This build could be faster, please consider using the Gradle Daemon: https: //docs.gradle.org/2.7/userguide/gradle_daemon.html [sekikn@localhost bigtop]$ ls /etc/puppet/modules/stdlib CHANGELOG.md examples LICENSE NOTICE README.markdown spec checksums.json Gemfile manifests Rakefile README_SPECS.markdown CONTRIBUTING.md lib metadata.json README_DEVELOPER.markdown RELEASE_PROCESS.markdown

          People

          • Assignee:
            sekikn Kengo Seki
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development