Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.1, 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: tests
    • Labels:
      None

      Activity

      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user chinmaykolhatkar closed the pull request at:

      https://github.com/apache/bigtop/pull/94

      Show
      githubbot ASF GitHub Bot added a comment - Github user chinmaykolhatkar closed the pull request at: https://github.com/apache/bigtop/pull/94
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user chinmaykolhatkar commented on the pull request:

      https://github.com/apache/bigtop/pull/94#issuecomment-211263230

      Closing as this PR is merged.

      Show
      githubbot ASF GitHub Bot added a comment - Github user chinmaykolhatkar commented on the pull request: https://github.com/apache/bigtop/pull/94#issuecomment-211263230 Closing as this PR is merged.
      Hide
      warwithin YoungWoo Kim added a comment -

      Chinmay Kolhatkar Sorry for my tardiness. I've just reviewed and tested the PR/94. I'll commit it shortly. Thanks for your effort!

      Show
      warwithin YoungWoo Kim added a comment - Chinmay Kolhatkar Sorry for my tardiness. I've just reviewed and tested the PR/94. I'll commit it shortly. Thanks for your effort!
      Hide
      chinmay Chinmay Kolhatkar added a comment -

      Hi,

      Can this PR be merged?

      Thanks,
      Chinmay.

      Show
      chinmay Chinmay Kolhatkar added a comment - Hi, Can this PR be merged? Thanks, Chinmay.
      Hide
      chinmay Chinmay Kolhatkar added a comment -

      Hi,

      I've made the changes as suggestion. Can this PR be merged?

      Thanks,
      Chinmay.

      Show
      chinmay Chinmay Kolhatkar added a comment - Hi, I've made the changes as suggestion. Can this PR be merged? Thanks, Chinmay.
      Hide
      chinmay Chinmay Kolhatkar added a comment -

      YoungWoo Kim I've seperated out the PR as you suggested.
      So the PR for this Jira is: https://github.com/apache/bigtop/pull/94

      And for the puppet recipes is: https://github.com/apache/bigtop/pull/96

      If you get chance please review the changes and merge once happy.

      Thanks,
      Chinmay.

      Show
      chinmay Chinmay Kolhatkar added a comment - YoungWoo Kim I've seperated out the PR as you suggested. So the PR for this Jira is: https://github.com/apache/bigtop/pull/94 And for the puppet recipes is: https://github.com/apache/bigtop/pull/96 If you get chance please review the changes and merge once happy. Thanks, Chinmay.
      Hide
      warwithin YoungWoo Kim added a comment -

      Chinmay Kolhatkar Thanks for the update. overall, it looks good to me but there are two commits in this pull request. so, it'd be good to move the commit for puppet recipe to another pull request: BIGTOP-2316 Thanks!

      Show
      warwithin YoungWoo Kim added a comment - Chinmay Kolhatkar Thanks for the update. overall, it looks good to me but there are two commits in this pull request. so, it'd be good to move the commit for puppet recipe to another pull request: BIGTOP-2316 Thanks!
      Hide
      chinmay Chinmay Kolhatkar added a comment -

      Updated the same PR wth puppet recipes as well as.

      Show
      chinmay Chinmay Kolhatkar added a comment - Updated the same PR wth puppet recipes as well as.
      Hide
      chinmay Chinmay Kolhatkar added a comment -

      Hi,

      I've updated the code as per recommended. The PR is now updated with all changes taken care of.

      Thanks,
      Chinmay.

      Show
      chinmay Chinmay Kolhatkar added a comment - Hi, I've updated the code as per recommended. The PR is now updated with all changes taken care of. Thanks, Chinmay.
      Hide
      chinmay Chinmay Kolhatkar added a comment -

      Somehow the comments for this PR got added to my public fork of bigtop.
      Here is the link to it:
      https://github.com/chinmaykolhatkar/bigtop/commit/84c0ea456cbec9fd8c53dc90190ec5bcc74f9c2d

      @cos Replied to your questions.

      Show
      chinmay Chinmay Kolhatkar added a comment - Somehow the comments for this PR got added to my public fork of bigtop. Here is the link to it: https://github.com/chinmaykolhatkar/bigtop/commit/84c0ea456cbec9fd8c53dc90190ec5bcc74f9c2d @cos Replied to your questions.
      Hide
      chinmay Chinmay Kolhatkar added a comment -
      Show
      chinmay Chinmay Kolhatkar added a comment - Patch is available at: https://github.com/apache/bigtop/pull/94
      Hide
      githubbot ASF GitHub Bot added a comment -

      GitHub user chinmaykolhatkar opened a pull request:

      https://github.com/apache/bigtop/pull/94

      BIGTOP-2315 Added smoke test for apex.

      Added smoke test for apache apex.

      You can merge this pull request into a Git repository by running:

      $ git pull https://github.com/chinmaykolhatkar/bigtop BIGTOP-2315

      Alternatively you can review and apply these changes as the patch at:

      https://github.com/apache/bigtop/pull/94.patch

      To close this pull request, make a commit to your master/trunk branch
      with (at least) the following in the commit message:

      This closes #94


      commit 84c0ea456cbec9fd8c53dc90190ec5bcc74f9c2d
      Author: chinmaykolhatkar <chinmay@datatorrent.com>
      Date: 2016-03-03T17:38:38Z

      BIGTOP-2315 Added smoke test for apex.


      Show
      githubbot ASF GitHub Bot added a comment - GitHub user chinmaykolhatkar opened a pull request: https://github.com/apache/bigtop/pull/94 BIGTOP-2315 Added smoke test for apex. Added smoke test for apache apex. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chinmaykolhatkar/bigtop BIGTOP-2315 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/94.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #94 commit 84c0ea456cbec9fd8c53dc90190ec5bcc74f9c2d Author: chinmaykolhatkar <chinmay@datatorrent.com> Date: 2016-03-03T17:38:38Z BIGTOP-2315 Added smoke test for apex.

        People

        • Assignee:
          chinmay Chinmay Kolhatkar
          Reporter:
          chinmay Chinmay Kolhatkar
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development