Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0
    • Component/s: build
    • Labels:
      None

      Description

      Bigtop before BIGTOP-2306 uses Grgit (groovy git) to clone git repos. Under the covers Grgit uses JGit. JGit's clone commend does not fetch any submodules during clone unless asked, and grgit does not ask. After BIGTOP-2306 we still should initialize and update submodules unconditionally. It's harmless to do this on repos which don't use submodules, and broken not to do so on repos which do use them.

      1. BIGTOP-2309.patch
        0.8 kB
        Andrew Purtell

        Activity

        Hide
        apurtell Andrew Purtell added a comment -

        Patch here depends on the changes in the latest patch on BIGTOP-2306, apply that first.

        Show
        apurtell Andrew Purtell added a comment - Patch here depends on the changes in the latest patch on BIGTOP-2306 , apply that first.
        Hide
        cos Konstantin Boudnik added a comment -

        Andrew Purtell is this going in? Looks like it has been ready for a while? Thanks!

        Show
        cos Konstantin Boudnik added a comment - Andrew Purtell is this going in? Looks like it has been ready for a while? Thanks!

          People

          • Assignee:
            apurtell Andrew Purtell
            Reporter:
            apurtell Andrew Purtell
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development