Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2306

Add support for specifying git repository access credentials

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: build
    • Labels:
      None

      Description

      Bigtop supports fetching component source from git repositories using grgit (Groovy git integration). Currently we expect all software sources are public repositories but we should support use cases where access credentials are required. We can do this by plumbing the Bigtop build control file to grgit.

      1. BIGTOP-2306.patch
        2 kB
        Andrew Purtell
      2. BIGTOP-2306.patch
        3 kB
        Andrew Purtell

        Issue Links

          Activity

          Hide
          rvs Roman Shaposhnik added a comment -

          Should be fixed now. Thanks Konstantin Boudnik!

          Show
          rvs Roman Shaposhnik added a comment - Should be fixed now. Thanks Konstantin Boudnik !
          Hide
          cos Konstantin Boudnik added a comment -

          No worries. I guess "stale" downloaded files have prevented you from testing this.

          Show
          cos Konstantin Boudnik added a comment - No worries. I guess "stale" downloaded files have prevented you from testing this.
          Hide
          rvs Roman Shaposhnik added a comment -

          Konstantin Boudnik my apologies! Working on a fix as we speak.

          Show
          rvs Roman Shaposhnik added a comment - Konstantin Boudnik my apologies! Working on a fix as we speak.
          Hide
          cos Konstantin Boudnik added a comment -

          Roman Shaposhnik, please be aware that once this patch was committed it broke download task of the build.

          Show
          cos Konstantin Boudnik added a comment - Roman Shaposhnik , please be aware that once this patch was committed it broke download task of the build.
          Hide
          cos Konstantin Boudnik added a comment -

          Andrew Purtell is this going in?

          Show
          cos Konstantin Boudnik added a comment - Andrew Purtell is this going in?
          Hide
          apurtell Andrew Purtell added a comment -

          With this improved version it's also possible for a user to skip the bigtop provided way of specifying access credentials and instead do git native things like set up a credential helper/cache in their gitconfig.

          Show
          apurtell Andrew Purtell added a comment - With this improved version it's also possible for a user to skip the bigtop provided way of specifying access credentials and instead do git native things like set up a credential helper/cache in their gitconfig.
          Hide
          apurtell Andrew Purtell added a comment -

          Here's a better version that also incorporates BIGTOP-2270.

          Tested with Enterprise GitHub

          Show
          apurtell Andrew Purtell added a comment - Here's a better version that also incorporates BIGTOP-2270 . Tested with Enterprise GitHub
          Hide
          oflebbe Olaf Flebbe added a comment -

          LGTM, but untested.

          Show
          oflebbe Olaf Flebbe added a comment - LGTM, but untested.
          Hide
          apurtell Andrew Purtell added a comment -

          First we check if the component definition in the BOM has defined <name>_GIT_USER_NAME and <name>_GIT_ACCESS_TOKEN. Then we try a global definition in the BOM for GIT_USER_NAME and GIT_ACCESS_TOKEN. If both have been defined we will clone using the supplied credentials.

          Show
          apurtell Andrew Purtell added a comment - First we check if the component definition in the BOM has defined <name>_GIT_USER_NAME and <name>_GIT_ACCESS_TOKEN. Then we try a global definition in the BOM for GIT_USER_NAME and GIT_ACCESS_TOKEN. If both have been defined we will clone using the supplied credentials.

            People

            • Assignee:
              apurtell Andrew Purtell
              Reporter:
              apurtell Andrew Purtell
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development