Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2236

GRADLE_USER_HOME should be set for bigtop/slaves images only

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: docker, toolchain
    • Labels:
      None

      Description

      Currently GRADLE_USER_HOME=/usr/share/gradle.home has been set in /etc/profile.d/bigtop.sh, therefore gradle downloaded packages are secretly stored in /usr/share/gradle.home instead of user home. This makes bigtop users confused(BIGTOP-2184) because they have no idea about /usr/share/gradle.home.
      Besides that, the cache mechanism is only needed by docker images. We should take off GRADLE_USER_HOME env variable in /etc/profile.d/bigtop.sh.

        Issue Links

          Activity

          Hide
          evans_ye Evans Ye added a comment -

          Committed.

          Show
          evans_ye Evans Ye added a comment - Committed.
          Hide
          evans_ye Evans Ye added a comment -

          Indeed that was an ugly fix done by me, that's why I'm back to pay my debt.

          Show
          evans_ye Evans Ye added a comment - Indeed that was an ugly fix done by me, that's why I'm back to pay my debt.
          Hide
          jonathak Jonathan Kelly added a comment -

          Ah, I'd wondered why this change had been made. It broke our CI (which is not using Docker yet) when I merged from github/master yesterday because our build machines run on EC2 instances as ec2-user, which do not have write access to /usr/share/gradle.home. So that's another reason not to set GRADLE_USER_HOME in bigtop.sh. Thanks for fixing this!

          Show
          jonathak Jonathan Kelly added a comment - Ah, I'd wondered why this change had been made. It broke our CI (which is not using Docker yet) when I merged from github/master yesterday because our build machines run on EC2 instances as ec2-user, which do not have write access to /usr/share/gradle.home. So that's another reason not to set GRADLE_USER_HOME in bigtop.sh. Thanks for fixing this!
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user evans-ye opened a pull request:

          https://github.com/apache/bigtop/pull/69

          BIGTOP-2236. GRADLE_USER_HOME should be set for bigtop/slaves images …

          …only

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/evans-ye/bigtop BIGTOP-2236

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/bigtop/pull/69.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #69


          commit 6c0536d9355e4c356281dfd950265f84d953a9ae
          Author: Evans Ye <evansye@apache.org>
          Date: 2016-01-13T17:09:16Z

          BIGTOP-2236. GRADLE_USER_HOME should be set for bigtop/slaves images only


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user evans-ye opened a pull request: https://github.com/apache/bigtop/pull/69 BIGTOP-2236 . GRADLE_USER_HOME should be set for bigtop/slaves images … …only You can merge this pull request into a Git repository by running: $ git pull https://github.com/evans-ye/bigtop BIGTOP-2236 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit 6c0536d9355e4c356281dfd950265f84d953a9ae Author: Evans Ye <evansye@apache.org> Date: 2016-01-13T17:09:16Z BIGTOP-2236 . GRADLE_USER_HOME should be set for bigtop/slaves images only

            People

            • Assignee:
              evans_ye Evans Ye
              Reporter:
              evans_ye Evans Ye
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development