Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2231

build.gradle carries one too many sets of repositories

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.2.0
    • Component/s: build
    • Labels:
      None

      Description

      Looks like build.gradle has duplicated declaration of the repositories in it. One is under allprojects and another one as at the very bottom.

      Also, there are two sets of subprojects declaration - needs to be fixed as well.

        Activity

        Hide
        cos Konstantin Boudnik added a comment -

        Pushed to the master.

        Show
        cos Konstantin Boudnik added a comment - Pushed to the master.
        Hide
        cos Konstantin Boudnik added a comment -

        What kind of issues were there, Olaf? I guess a few bugs were ironed out in the last release and since. May there's something else I am not aware of?
        I will commit this now and we'll see if nothing changes, which would be expected.

        Show
        cos Konstantin Boudnik added a comment - What kind of issues were there, Olaf? I guess a few bugs were ironed out in the last release and since. May there's something else I am not aware of? I will commit this now and we'll see if nothing changes, which would be expected.
        Hide
        oflebbe Olaf Flebbe added a comment -

        Looks reasonable. I didn't test it, though. IIRC there were issues in the iTest things in the past

        Show
        oflebbe Olaf Flebbe added a comment - Looks reasonable. I didn't test it, though. IIRC there were issues in the iTest things in the past
        Hide
        cos Konstantin Boudnik added a comment -

        Here's a patch that seems to be addressing the issue without breaking anything at the first glance. Shall we get it in and see if the CI can find anything? Olaf Flebbe, what do you think? Thanks!

        Show
        cos Konstantin Boudnik added a comment - Here's a patch that seems to be addressing the issue without breaking anything at the first glance. Shall we get it in and see if the CI can find anything? Olaf Flebbe , what do you think? Thanks!
        Hide
        cos Konstantin Boudnik added a comment -

        After a quick glance over the code, looks like we aren't indeed using the snapshots anywhere. I guess these were copied from the Maven build or something.
        The only reason for using them is when one needs to use iTest snapshot without installing it locally first. But this seems like a weak case.

        Show
        cos Konstantin Boudnik added a comment - After a quick glance over the code, looks like we aren't indeed using the snapshots anywhere. I guess these were copied from the Maven build or something. The only reason for using them is when one needs to use iTest snapshot without installing it locally first. But this seems like a weak case.
        Hide
        oflebbe Olaf Flebbe added a comment -

        Can we get rid of the snapshot repositories? snapshot repositories are volatile and artifacts can be deleted at any time.

        We should not use snapshot repositories in releases.

        Show
        oflebbe Olaf Flebbe added a comment - Can we get rid of the snapshot repositories? snapshot repositories are volatile and artifacts can be deleted at any time. We should not use snapshot repositories in releases.

          People

          • Assignee:
            cos Konstantin Boudnik
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development