Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2220

flume-agent.init incorrectly handles flume.conf

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      The function run_functions_on_conf() in flume-agent.init uses flume.conf as a configuration for an agent named 'flume'. Therefore, the script searches flume-flume.conf and fails.

      1. BIGTOP-2220.patch
        1 kB
        Teruyoshi Zenmyo
      2. BIGTOP-2220_2.patch
        1 kB
        Teruyoshi Zenmyo

        Activity

        Hide
        tzenmyo Teruyoshi Zenmyo added a comment -

        Applying this patch, the flume-agent.init ignores the flume.conf when any other agent configuration exists. Otherwise, the flume.conf is used as one of the default agent.

        Show
        tzenmyo Teruyoshi Zenmyo added a comment - Applying this patch, the flume-agent.init ignores the flume.conf when any other agent configuration exists. Otherwise, the flume.conf is used as one of the default agent.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user zenmyo opened a pull request:

        https://github.com/apache/bigtop/pull/85

        BIGTOP-2220 : flume-agent.init incorrectly handles flume.conf

        The function `run_functions_on_conf()` in flume-agent.init uses `flume.conf` as a configuration for an agent named 'flume'. Therefore, the script searches `flume-flume.conf` and fails.

        https://issues.apache.org/jira/browse/BIGTOP-2220

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/zenmyo/bigtop BIGTOP-2220

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/bigtop/pull/85.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #85


        commit 3fa0791ec4b72f6d8270f43a22bf8e11ab2826e0
        Author: zenmyo <tzenmyo@gmail.com>
        Date: 2016-01-07T05:21:11Z

        BIGTOP-2220 : flume-agent.init incorrectly handles flume.conf


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user zenmyo opened a pull request: https://github.com/apache/bigtop/pull/85 BIGTOP-2220 : flume-agent.init incorrectly handles flume.conf The function `run_functions_on_conf()` in flume-agent.init uses `flume.conf` as a configuration for an agent named 'flume'. Therefore, the script searches `flume-flume.conf` and fails. https://issues.apache.org/jira/browse/BIGTOP-2220 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zenmyo/bigtop BIGTOP-2220 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/85.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #85 commit 3fa0791ec4b72f6d8270f43a22bf8e11ab2826e0 Author: zenmyo <tzenmyo@gmail.com> Date: 2016-01-07T05:21:11Z BIGTOP-2220 : flume-agent.init incorrectly handles flume.conf
        Hide
        warwithin YoungWoo Kim added a comment -

        Teruyoshi Zenmyo, IMO, the init script for flume agent should not ignore flume.conf or rather, if there is flume.conf, we should launch the agent as DEFAULT_FLUME_AGENT_NAME

        Show
        warwithin YoungWoo Kim added a comment - Teruyoshi Zenmyo , IMO, the init script for flume agent should not ignore flume.conf or rather, if there is flume.conf, we should launch the agent as DEFAULT_FLUME_AGENT_NAME
        Hide
        tzenmyo Teruyoshi Zenmyo added a comment -

        YoungWoo Kim Thanks for the comment. I have updated the patch which launch the default agent with `flume.conf`.

        Show
        tzenmyo Teruyoshi Zenmyo added a comment - YoungWoo Kim Thanks for the comment. I have updated the patch which launch the default agent with `flume.conf`.
        Hide
        warwithin YoungWoo Kim added a comment -

        +1, LGTM!
        Would like to commit it but can't assign this to Teruyoshi Zenmyo by myself. Please add Teruyoshi Zenmyo to Bigtop contributor list.

        Show
        warwithin YoungWoo Kim added a comment - +1, LGTM! Would like to commit it but can't assign this to Teruyoshi Zenmyo by myself. Please add Teruyoshi Zenmyo to Bigtop contributor list.
        Hide
        tzenmyo Teruyoshi Zenmyo added a comment -

        Thanks for the review.
        I can't assign this ticket to me by myself because "Assign to me" link is not visible to me. Should I do anything else?

        Show
        tzenmyo Teruyoshi Zenmyo added a comment - Thanks for the review. I can't assign this ticket to me by myself because "Assign to me" link is not visible to me. Should I do anything else?
        Hide
        warwithin YoungWoo Kim added a comment -

        Evans Ye Thanks!

        Show
        warwithin YoungWoo Kim added a comment - Evans Ye Thanks!
        Hide
        warwithin YoungWoo Kim added a comment -

        committed. Thank you Teruyoshi Zenmyo for your contribution!

        Show
        warwithin YoungWoo Kim added a comment - committed. Thank you Teruyoshi Zenmyo for your contribution!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user zenmyo closed the pull request at:

        https://github.com/apache/bigtop/pull/85

        Show
        githubbot ASF GitHub Bot added a comment - Github user zenmyo closed the pull request at: https://github.com/apache/bigtop/pull/85

          People

          • Assignee:
            tzenmyo Teruyoshi Zenmyo
            Reporter:
            tzenmyo Teruyoshi Zenmyo
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development