Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2175

BIGTOP_HOME should be either asserter or replaced with setup logic

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.1.0
    • Component/s: tests
    • Labels:
      None

      Description

      Right now, if {{BIGTOP_HOME} sysenv isn't set, the new smoke-tests will complete without running anything and not complaining that a required variable isn't set.

      The setting has to be either

      1. enforced like for ITEST_HOME
      2. some setup logic to be added to just setup the variable without user intervention
      3. removed completely

        Issue Links

          Activity

          Hide
          cos Konstantin Boudnik added a comment -

          David Capwell, I have moved your patch in here, so we can keep on working on the Unified JIRA, independently

          Show
          cos Konstantin Boudnik added a comment - David Capwell , I have moved your patch in here, so we can keep on working on the Unified JIRA, independently
          Hide
          evans_ye Evans Ye added a comment -

          +1 on the patch.
          BTW, do you think we can automatically export those variables in gradle? Or maybe we can use puppet to drop a file in profile.d just like what we did for jenkins.sh. I don't have a clear thought yet.
          It's a pain in my back that bigtop/bigtop-deploy/vm/utils/smoke-tests.sh looks completely like a workaround.

          Show
          evans_ye Evans Ye added a comment - +1 on the patch. BTW, do you think we can automatically export those variables in gradle? Or maybe we can use puppet to drop a file in profile.d just like what we did for jenkins.sh. I don't have a clear thought yet. It's a pain in my back that bigtop/bigtop-deploy/vm/utils/smoke-tests.sh looks completely like a workaround.
          Hide
          cos Konstantin Boudnik added a comment -

          Agree! I have moved the patch into a separate JIRA to keep the original ticket open with its discussion on the topic and such. I am pretty sure we can improve the smokes setup quite a bit.

          Show
          cos Konstantin Boudnik added a comment - Agree! I have moved the patch into a separate JIRA to keep the original ticket open with its discussion on the topic and such. I am pretty sure we can improve the smokes setup quite a bit.
          Hide
          cos Konstantin Boudnik added a comment -

          Pushed to the master.

          Show
          cos Konstantin Boudnik added a comment - Pushed to the master.

            People

            • Assignee:
              dcapwell David Capwell
              Reporter:
              cos Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development