Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1309 Gradle environment overhaul
  3. BIGTOP-2055

Refactor packages.gradle to get rid of excessive data containers; make code cleaner

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: build
    • Labels:
      None

      Description

      With all-gradle build for packages, it is time to clean it a little bit. There are some spots of code dups, less then optimal use of intermediate data containers, etc.

      1. BIGTOP-2055.patch
        6 kB
        Konstantin Boudnik

        Activity

        Hide
        cos Konstantin Boudnik added a comment -
        • renamed some vars to make them less ubiquitous
        • in-lining some methods
        • removing code duplicates through methods extraction
        Show
        cos Konstantin Boudnik added a comment - renamed some vars to make them less ubiquitous in-lining some methods removing code duplicates through methods extraction
        Hide
        jayunit100 jay vyas added a comment - - edited

        At first glance, think this looks cleaner, again, if its tested +1...
        but i'd love for other folks more directly using the bigtop system right now to review it .
        Again, if you're confident this is working lets get it in

        Show
        jayunit100 jay vyas added a comment - - edited At first glance, think this looks cleaner, again, if its tested +1... but i'd love for other folks more directly using the bigtop system right now to review it . Again, if you're confident this is working lets get it in
        Hide
        cos Konstantin Boudnik added a comment -

        The change is pretty trivial and yes, it works Will get it in over the weekend - no rush, thanks for the review.

        Show
        cos Konstantin Boudnik added a comment - The change is pretty trivial and yes, it works Will get it in over the weekend - no rush, thanks for the review.
        Hide
        cos Konstantin Boudnik added a comment -

        Pushed to the master. Thanks for the review.

        Show
        cos Konstantin Boudnik added a comment - Pushed to the master. Thanks for the review.

          People

          • Assignee:
            cos Konstantin Boudnik
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development