Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2037

BIGTOP-1746 Added Files Without Apache License Headers

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: deployment
    • Labels:
      None

      Description

      BIGTOP-1746 added files under bigtop-deploy/puppet/modules/bigtop-util/ that don't have Apache license headers and break the Apache RAT check.

      vishnu gajendran, Evans Ye could you take a look?

        Issue Links

          Activity

          Hide
          evans_ye Evans Ye added a comment -

          I forgot to run mvn apache-rat:check. Sorry.
          vishnu gajendran would you like to submit a patch for this?

          Show
          evans_ye Evans Ye added a comment - I forgot to run mvn apache-rat:check . Sorry. vishnu gajendran would you like to submit a patch for this?
          Hide
          cos Konstantin Boudnik added a comment -

          I also see that we added the dependencies on rake and rspec-puppet. Both are under MIT license and need to be listed under NOTICE.
          Basically, if ever in doubt about some license - refer to https://www.apache.org/legal/resolved.html#category-a

          Show
          cos Konstantin Boudnik added a comment - I also see that we added the dependencies on rake and rspec-puppet. Both are under MIT license and need to be listed under NOTICE . Basically, if ever in doubt about some license - refer to https://www.apache.org/legal/resolved.html#category-a
          Hide
          vishnu vishnu gajendran added a comment -

          Hi Konstantin,

          Thanks you. So, should I just include

          https://opensource.org/licenses/MIT

          in the existing NOTICE file under list of included license?

          Show
          vishnu vishnu gajendran added a comment - Hi Konstantin, Thanks you. So, should I just include https://opensource.org/licenses/MIT in the existing NOTICE file under list of included license?
          Hide
          cos Konstantin Boudnik added a comment -

          Yeah, basically follow the lead of FreeBSD line. Thanks

          Show
          cos Konstantin Boudnik added a comment - Yeah, basically follow the lead of FreeBSD line. Thanks
          Hide
          cos Konstantin Boudnik added a comment -

          Kengo Seki has provided a patch for it on BIGTOP-2045. Perhaps this JIRA should be assigned to Kengo if no progress has been made here just yet?

          Show
          cos Konstantin Boudnik added a comment - Kengo Seki has provided a patch for it on BIGTOP-2045 . Perhaps this JIRA should be assigned to Kengo if no progress has been made here just yet?
          Hide
          vishnu vishnu gajendran added a comment -

          Thank a lot Kengo for addressing the issue. Please assign this issue to Kengo and resolve. Thanks.

          Show
          vishnu vishnu gajendran added a comment - Thank a lot Kengo for addressing the issue. Please assign this issue to Kengo and resolve. Thanks.
          Hide
          cos Konstantin Boudnik added a comment -

          Kengo Seki, could you please move the patch here with appropriate changes in the commit message? I have added you to the project's contributors list, so the ticket is assigned to you now. Thanks!

          Show
          cos Konstantin Boudnik added a comment - Kengo Seki , could you please move the patch here with appropriate changes in the commit message? I have added you to the project's contributors list, so the ticket is assigned to you now. Thanks!
          Hide
          sekikn Kengo Seki added a comment -

          Thanks Konstantin Boudnik vishnu gajendran, attaching a patch. In addition to the patch provided on BIGTOP-2045, I listed MIT license under NOTICE.

          Show
          sekikn Kengo Seki added a comment - Thanks Konstantin Boudnik vishnu gajendran , attaching a patch. In addition to the patch provided on BIGTOP-2045 , I listed MIT license under NOTICE .
          Hide
          rnowling RJ Nowling added a comment -

          +1. I'll go ahead and commit. Thank you for your contribution, Kengo Seki!

          Show
          rnowling RJ Nowling added a comment - +1. I'll go ahead and commit. Thank you for your contribution, Kengo Seki !
          Hide
          rnowling RJ Nowling added a comment -

          Tested with Gradle and Maven. Committed.

          Show
          rnowling RJ Nowling added a comment - Tested with Gradle and Maven. Committed.

            People

            • Assignee:
              sekikn Kengo Seki
              Reporter:
              rnowling RJ Nowling
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development