Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-2026

Phoenix build defines HBASE_VERSION in two different places.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: debian, rpm
    • Labels:
      None

      Description

      % ack-grep PHOENIX_HBASE_VERSION *
      bigtop.mk
      282:PHOENIX_HBASE_VERSION=HBase-0.98
      283:PHOENIX_TARBALL_DST=phoenix-$(PHOENIX_BASE_VERSION)-$(PHOENIX_HBASE_VERSION)-src.tar.gz
      285:PHOENIX_DOWNLOAD_PATH=/phoenix/phoenix-$(PHOENIX_BASE_VERSION)-$(PHOENIX_HBASE_VERSION)/src/
      
      bigtop-packages/src/common/phoenix/do-component-build
      21:PHOENIX_HBASE_VERSION=HBase-0.98
      32:tar -C build --strip-components=1 -xzf phoenix-assembly/target/phoenix-$PHOENIX_VERSION-${PHOENIX_HBASE_VERSION}.tar.gz
      

      The variable is defined twice and can lead to integration problems if it gets changed independently. do-component-build should use the one from the BOM

      1. BIGTOP-2026.patch
        3 kB
        Andrew Purtell
      2. BIGTOP-2026.patch
        4 kB
        Andrew Purtell

        Activity

        Hide
        apurtell Andrew Purtell added a comment -

        Great, pushed to master

        Show
        apurtell Andrew Purtell added a comment - Great, pushed to master
        Hide
        cos Konstantin Boudnik added a comment -

        +1 thank you!

        Show
        cos Konstantin Boudnik added a comment - +1 thank you!
        Hide
        apurtell Andrew Purtell added a comment -

        No problem! Easy to see what to do with the new DSL. Updated patch attached. Tested the deb build again, works fine.

        Show
        apurtell Andrew Purtell added a comment - No problem! Easy to see what to do with the new DSL. Updated patch attached. Tested the deb build again, works fine.
        Hide
        cos Konstantin Boudnik added a comment -

        Andrew, that looks like a right thing and thanks for testing it! The only thing: with BIGTOP-1494 in place you'll need to refactor bigtop.mk part and make the change in bigtop.bom file, which is the new stack config. It should be all easy to do, but if you need any help - ping me here or on the IRC and I'd be happy to help!

        Show
        cos Konstantin Boudnik added a comment - Andrew, that looks like a right thing and thanks for testing it! The only thing: with BIGTOP-1494 in place you'll need to refactor bigtop.mk part and make the change in bigtop.bom file, which is the new stack config. It should be all easy to do, but if you need any help - ping me here or on the IRC and I'd be happy to help!
        Hide
        apurtell Andrew Purtell added a comment -

        This was hardcoded in several places and isn't needed.

        Patch tested with gradle phoenix-deb on Ubuntu 14.04, and gradle phoenix-rpm on Amazon Linux (a RHEL derivative). Builds succeed.

        Show
        apurtell Andrew Purtell added a comment - This was hardcoded in several places and isn't needed. Patch tested with gradle phoenix-deb on Ubuntu 14.04, and gradle phoenix-rpm on Amazon Linux (a RHEL derivative). Builds succeed.
        Hide
        apurtell Andrew Purtell added a comment -

        Let me fix this nit

        Show
        apurtell Andrew Purtell added a comment - Let me fix this nit

          People

          • Assignee:
            apurtell Andrew Purtell
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development