Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: build, spark
    • Labels:
      None

      Description

      SCALA_HOME isn't required by Spark and Kafka since Scala is retrieved by Maven.

        Activity

        Hide
        rnowling RJ Nowling added a comment -

        No worries, Mark Grover. Thank you!

        Show
        rnowling RJ Nowling added a comment - No worries, Mark Grover . Thank you!
        Hide
        mgrover Mark Grover added a comment -

        Apologies for the delay, RJ. LGTM too.

        Show
        mgrover Mark Grover added a comment - Apologies for the delay, RJ. LGTM too.
        Hide
        rnowling RJ Nowling added a comment -

        Thanks Andrew Purtell !

        Show
        rnowling RJ Nowling added a comment - Thanks Andrew Purtell !
        Hide
        rnowling RJ Nowling added a comment -

        Committed

        Show
        rnowling RJ Nowling added a comment - Committed
        Hide
        apurtell Andrew Purtell added a comment -

        Tested with unset SCALA_HOME followed by gradle spark-deb and gradle kafka-deb, Mint 17.2 (Ubuntu 14.04)

        +1

        Show
        apurtell Andrew Purtell added a comment - Tested with unset SCALA_HOME followed by gradle spark-deb and gradle kafka-deb , Mint 17.2 (Ubuntu 14.04) +1
        Hide
        rnowling RJ Nowling added a comment -

        I removed references to SCALA_HOME in the Spark and Kafka build and install scripts and all other references in the project.

        I tested the changes by running gradle spark-rpm and gradle kafka-rpm. I would encourage further testing, especially with Debian packages.

        Mark Grover, YoungWoo Kim would you mind reviewing this?

        Show
        rnowling RJ Nowling added a comment - I removed references to SCALA_HOME in the Spark and Kafka build and install scripts and all other references in the project. I tested the changes by running gradle spark-rpm and gradle kafka-rpm . I would encourage further testing, especially with Debian packages. Mark Grover , YoungWoo Kim would you mind reviewing this?

          People

          • Assignee:
            rnowling RJ Nowling
            Reporter:
            rnowling RJ Nowling
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development