Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: tests
    • Labels:
      None

      Description

      Add below tests related to HDFS admin module to the existing test class file TestHDFSBalancer.groovy:

      • test threshold with negative value.
      • test threshold with zero value.
      • test threshold with max value.
      1. BIGTOP-1973.patch
        7 kB
        Venkata Srinivasa Rao Kolla

        Activity

        Hide
        kollavenkat Venkata Srinivasa Rao Kolla added a comment -

        Patch with newly added test cases for TestHDFSBalancer.groovy

        Show
        kollavenkat Venkata Srinivasa Rao Kolla added a comment - Patch with newly added test cases for TestHDFSBalancer.groovy
        Hide
        warwithin YoungWoo Kim added a comment - - edited

        Thanks Venkata Srinivasa Rao Kolla , Looks good to me and new tests work fine for me!

        After all, static member 'thresh' will never be used, right? so it would be perfect if related lines are removed!

        ...
        
          private static String thresh = "10";
        
          @BeforeClass
          public static void setUp() {
        
            // unpack resource
            JarContent.unpackJarContainer(TestHDFSBalancer.class, ".", null);
            if (System.getProperty("threshold") != null) {
              thresh = System.getProperty("threshold");
            }
          }
        
        ...
        
        Show
        warwithin YoungWoo Kim added a comment - - edited Thanks Venkata Srinivasa Rao Kolla , Looks good to me and new tests work fine for me! After all, static member 'thresh' will never be used, right? so it would be perfect if related lines are removed! ... private static String thresh = "10" ; @BeforeClass public static void setUp() { // unpack resource JarContent.unpackJarContainer(TestHDFSBalancer.class, "." , null ); if ( System .getProperty( "threshold" ) != null ) { thresh = System .getProperty( "threshold" ); } } ...
        Hide
        kollavenkat Venkata Srinivasa Rao Kolla added a comment -

        Hi YoungWoo,

        Thanks a lot for the quick update.

        There is an existing test in this file using thresh, so i have retained this part for that test:
        @Test
        public void testBalancerWithProperThresholdValue()

        { testBalancerWithThreshold(thresh, false, ""); }

        With Best Regards,
        Srinivas.

        Show
        kollavenkat Venkata Srinivasa Rao Kolla added a comment - Hi YoungWoo, Thanks a lot for the quick update. There is an existing test in this file using thresh, so i have retained this part for that test: @Test public void testBalancerWithProperThresholdValue() { testBalancerWithThreshold(thresh, false, ""); } With Best Regards, Srinivas.
        Hide
        warwithin YoungWoo Kim added a comment -

        Please add Srinivas(Venkata Srinivasa Rao Kolla ) to Bigtop contributor list or just assign this to Srinivas. Thanks!

        Show
        warwithin YoungWoo Kim added a comment - Please add Srinivas( Venkata Srinivasa Rao Kolla ) to Bigtop contributor list or just assign this to Srinivas. Thanks!
        Hide
        warwithin YoungWoo Kim added a comment -

        Oh, My bad You're right!

        +1

        Thank you Venkata Srinivasa Rao Kolla !

        Show
        warwithin YoungWoo Kim added a comment - Oh, My bad You're right! +1 Thank you Venkata Srinivasa Rao Kolla !
        Hide
        evans_ye Evans Ye added a comment -

        Done. Thank you both for collaborating on this.

        Show
        evans_ye Evans Ye added a comment - Done. Thank you both for collaborating on this.
        Hide
        kollavenkat Venkata Srinivasa Rao Kolla added a comment -

        Thanks for adding me Team.
        Can we mark this sub task (BIGTOP-1973) as resolved now? Please let me know if anything else is pending to mark this task as resolved.

        Show
        kollavenkat Venkata Srinivasa Rao Kolla added a comment - Thanks for adding me Team. Can we mark this sub task ( BIGTOP-1973 ) as resolved now? Please let me know if anything else is pending to mark this task as resolved.
        Hide
        warwithin YoungWoo Kim added a comment -

        Will commit this shortly! Thanks Venkata Srinivasa Rao Kolla

        Show
        warwithin YoungWoo Kim added a comment - Will commit this shortly! Thanks Venkata Srinivasa Rao Kolla
        Hide
        warwithin YoungWoo Kim added a comment -

        Thanks Evans.

        Show
        warwithin YoungWoo Kim added a comment - Thanks Evans.

          People

          • Assignee:
            kollavenkat Venkata Srinivasa Rao Kolla
            Reporter:
            kollavenkat Venkata Srinivasa Rao Kolla
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development