Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1960

The smoke-test wrapper in bigtop-deploy can only be used in redhat series of Linux

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: deployment, tests
    • Labels:
      None

      Description

      In bigtop-deploy/vm/utils/smoke-tests.sh, the JAVA_HOME is hard coded to /usr/lib/jvm/java-openjdk which cause the smoke test failed to run on debian, ubuntu, etc. We should auto detect the JAVA_HOME by leveraging bigtop-utils so that it supports all the OS bigtop supported.

      1. BIGTOP-1960.patch
        1 kB
        Evans Ye
      2. BIGTOP-1960.patch
        1 kB
        Evans Ye

        Activity

        Hide
        evans_ye Evans Ye added a comment -

        Patch attached.

        Show
        evans_ye Evans Ye added a comment - Patch attached.
        Hide
        cos Konstantin Boudnik added a comment -

        Evans, the change is based on the assumption that bigtop-utils package is installed, right? Which might or might not be the case. Do you think it'd be beneficial to add the test to see if the /usr/lib/bigtop-utils/bigtop-detect-javahome file exists and only then source it? Otherwise, the script will be producing the error exit code.

        Show
        cos Konstantin Boudnik added a comment - Evans, the change is based on the assumption that bigtop-utils package is installed, right? Which might or might not be the case. Do you think it'd be beneficial to add the test to see if the /usr/lib/bigtop-utils/bigtop-detect-javahome file exists and only then source it? Otherwise, the script will be producing the error exit code.
        Hide
        evans_ye Evans Ye added a comment -

        Good point Konstantin Boudnik. Thanks for your constructive suggestion. I've uploaded a new patch to address your comment.

        Show
        evans_ye Evans Ye added a comment - Good point Konstantin Boudnik . Thanks for your constructive suggestion. I've uploaded a new patch to address your comment.
        Hide
        evans_ye Evans Ye added a comment -

        Can someone review this?
        To better support our CTR trial model. It would be great to have this patch in so that we can do smoke tests for hadoop on debian as well. See our deplyoment CI job.

        Show
        evans_ye Evans Ye added a comment - Can someone review this? To better support our CTR trial model. It would be great to have this patch in so that we can do smoke tests for hadoop on debian as well. See our deplyoment CI job .
        Hide
        cos Konstantin Boudnik added a comment -

        I am sorry - I missed that one. +1 - everything looks right, but I haven't run, honestly.

        Show
        cos Konstantin Boudnik added a comment - I am sorry - I missed that one. +1 - everything looks right, but I haven't run, honestly.
        Hide
        evans_ye Evans Ye added a comment -

        We now have CI safe-guard start working for smoke tests!
        http://ci.bigtop.apache.org:8080/view/Deployment/job/Bigtop-Docker-provisioner

        Show
        evans_ye Evans Ye added a comment - We now have CI safe-guard start working for smoke tests! http://ci.bigtop.apache.org:8080/view/Deployment/job/Bigtop-Docker-provisioner
        Hide
        cos Konstantin Boudnik added a comment -

        Looks like the master is down?

        Show
        cos Konstantin Boudnik added a comment - Looks like the master is down?
        Hide
        evans_ye Evans Ye added a comment -

        I see it is still running.

        Show
        evans_ye Evans Ye added a comment - I see it is still running.
        Hide
        evans_ye Evans Ye added a comment -

        The patch has been committed so here I close the JIRA as fixed.

        Show
        evans_ye Evans Ye added a comment - The patch has been committed so here I close the JIRA as fixed.
        Hide
        cos Konstantin Boudnik added a comment -

        Looks like hotel proxy doesn't let me through... sorry for the false alarm.

        Show
        cos Konstantin Boudnik added a comment - Looks like hotel proxy doesn't let me through... sorry for the false alarm.

          People

          • Assignee:
            evans_ye Evans Ye
            Reporter:
            evans_ye Evans Ye
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development