Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1940

Consider removing tests expecting 'sudo' from skip-list

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.2.0
    • Fix Version/s: 1.1.0
    • Component/s: tests
    • Labels:
      None

      Description

      Right now a test that validates iTest's functionality to elevate user privileges is set to be skipped

        @Ignore("requires sudo")
      

      the test actually works quite fine if password-less sudo is configured. And such configuration is a requirement for some other tests as well. Shall we consider making password-less sudo an official requirement for the tests and allow this test case?

      Another option would be to change @Ignote to @Assume and make an explicit check for password-less sudo

      Thoughts?

        Activity

        Hide
        cos Konstantin Boudnik added a comment -

        committed and pushed to the master.

        Show
        cos Konstantin Boudnik added a comment - committed and pushed to the master.
        Hide
        jayunit100 jay vyas added a comment -

        Thanks this looks exactly like what we need. Assuming you've tested it +1 !
        Sorry I didn't see this earlier .

        Show
        jayunit100 jay vyas added a comment - Thanks this looks exactly like what we need. Assuming you've tested it +1 ! Sorry I didn't see this earlier .
        Hide
        cos Konstantin Boudnik added a comment -

        Any input? Looks like RTC really works

        Show
        cos Konstantin Boudnik added a comment - Any input? Looks like RTC really works
        Hide
        cos Konstantin Boudnik added a comment -

        Any other reviewers?

        Show
        cos Konstantin Boudnik added a comment - Any other reviewers?
        Hide
        cos Konstantin Boudnik added a comment -

        How about this? Validated it with both modes of sudo: tests pass in both cases. When password-less is disabled the number of ignored tests is higher by 7

        Show
        cos Konstantin Boudnik added a comment - How about this? Validated it with both modes of sudo: tests pass in both cases. When password-less is disabled the number of ignored tests is higher by 7
        Hide
        jayunit100 jay vyas added a comment - - edited

        im ok if the test fails very clearly if passwordless sudo is not there, stating that passwordless sudo is required.
        otherwise it will be quite confusing

        Show
        jayunit100 jay vyas added a comment - - edited im ok if the test fails very clearly if passwordless sudo is not there, stating that passwordless sudo is required. otherwise it will be quite confusing

          People

          • Assignee:
            cos Konstantin Boudnik
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development