Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: documentation
    • Labels:
      None

      Description

      Update README for bigtop_toolchain (version 1.0.0)

      1. BIGTOP-1794.1.patch
        2 kB
        YoungWoo Kim
      2. BIGTOP-1794.2.patch
        4 kB
        YoungWoo Kim

        Activity

        Hide
        warwithin YoungWoo Kim added a comment -

        BIGTOP-1794.1.patch:

        • Revise README for bigtop_toolchain
        Show
        warwithin YoungWoo Kim added a comment - BIGTOP-1794.1.patch : Revise README for bigtop_toolchain
        Hide
        warwithin YoungWoo Kim added a comment -

        Updated patch, BIGTOP-1794.2.patch

        Show
        warwithin YoungWoo Kim added a comment - Updated patch, BIGTOP-1794.2.patch
        Hide
        evans_ye Evans Ye added a comment -

        Hey YoungWoo Kim it looks like we'll remove JAVA_HOME in BIGTOP-1793. Then we should not have this line in README
        JAVA_HOME=/usr/lib/jvm/java-1.7.0-openjdk.x86_64
        Am I getting it right?

        BTW I remember there's rule that updating documents does not need to get a +1 to commit Konstantin Boudnik?

        Show
        evans_ye Evans Ye added a comment - Hey YoungWoo Kim it looks like we'll remove JAVA_HOME in BIGTOP-1793 . Then we should not have this line in README JAVA_HOME=/usr/lib/jvm/java-1.7.0-openjdk.x86_64 Am I getting it right? BTW I remember there's rule that updating documents does not need to get a +1 to commit Konstantin Boudnik ?
        Hide
        cos Konstantin Boudnik added a comment -

        Yup. Documentation updates aren't the subject to reviews as we have agreed upon a while back.

        Show
        cos Konstantin Boudnik added a comment - Yup. Documentation updates aren't the subject to reviews as we have agreed upon a while back.
        Hide
        warwithin YoungWoo Kim added a comment - - edited

        Evans Ye, Thanks for your comment. An environment variable 'JAVA_HOME' does not removed. Actually '$JAVA_HOME/bin' is not needed from the PATH variable anymore because as of now, bigtop_toolchain does install JDK from base packages on supported OSs.

        BIGTOP-1793, I just removed '$JAVA_HOME/bin' from PATH:

        -export PATH=$JAVA7_HOME/bin:$MAVEN_HOME/bin:$ANT_HOME/bin:$FORREST_HOME/bin:$GRADLE_HOME/bin:$PATH
        +export PATH=$MAVEN_HOME/bin:$ANT_HOME/bin:$FORREST_HOME/bin:$GRADLE_HOME/bin:$PATH
        
        Show
        warwithin YoungWoo Kim added a comment - - edited Evans Ye , Thanks for your comment. An environment variable 'JAVA_HOME' does not removed. Actually '$JAVA_HOME/bin' is not needed from the PATH variable anymore because as of now, bigtop_toolchain does install JDK from base packages on supported OSs. BIGTOP-1793 , I just removed '$JAVA_HOME/bin' from PATH: -export PATH=$JAVA7_HOME/bin:$MAVEN_HOME/bin:$ANT_HOME/bin:$FORREST_HOME/bin:$GRADLE_HOME/bin:$PATH +export PATH=$MAVEN_HOME/bin:$ANT_HOME/bin:$FORREST_HOME/bin:$GRADLE_HOME/bin:$PATH
        Hide
        evans_ye Evans Ye added a comment -

        Got it. Thanks for explaining. +1 to the patch.

        Show
        evans_ye Evans Ye added a comment - Got it. Thanks for explaining. +1 to the patch.
        Hide
        warwithin YoungWoo Kim added a comment -

        Committed.

        Show
        warwithin YoungWoo Kim added a comment - Committed.

          People

          • Assignee:
            warwithin YoungWoo Kim
            Reporter:
            warwithin YoungWoo Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development