Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1793

bigtop_toolchain: remove JAVA_HOME/bin from PATH

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: None
    • Labels:
      None

      Description

      From BIGTOP-1780, it has been removed 'JAVA[6,7]_HOME' env variables. So it should be removed remaining 'JAVA7_HOME'.

      1. BIGTOP-1793.1.patch
        0.9 kB
        YoungWoo Kim
      2. BIGTOP-1793.2.patch
        2 kB
        YoungWoo Kim

        Activity

        Hide
        warwithin YoungWoo Kim added a comment -

        BIGTOP-1793.1.patch:

        • Remove JAVA7_HOME
        Show
        warwithin YoungWoo Kim added a comment - BIGTOP-1793.1.patch : Remove JAVA7_HOME
        Hide
        oflebbe Olaf Flebbe added a comment -

        I would propose to remove the JAVA_HOME from the path alltogether, since we use the system package which already includes itself correctly in PATH.

        Something like

        PATH=$MAVEN_HOME/bin:$ANT_HOME/bin:$FORREST_HOME/bin:$GRADLE_HOME/bin:$PATH
        
        Show
        oflebbe Olaf Flebbe added a comment - I would propose to remove the JAVA_HOME from the path alltogether, since we use the system package which already includes itself correctly in PATH. Something like PATH=$MAVEN_HOME/bin:$ANT_HOME/bin:$FORREST_HOME/bin:$GRADLE_HOME/bin:$PATH
        Hide
        oflebbe Olaf Flebbe added a comment -

        I would propose to remove the JAVA_HOME from the path alltogether, since we use the system package which already includes itself correctly in PATH.

        Something like

        PATH=$MAVEN_HOME/bin:$ANT_HOME/bin:$FORREST_HOME/bin:$GRADLE_HOME/bin:$PATH
        
        Show
        oflebbe Olaf Flebbe added a comment - I would propose to remove the JAVA_HOME from the path alltogether, since we use the system package which already includes itself correctly in PATH. Something like PATH=$MAVEN_HOME/bin:$ANT_HOME/bin:$FORREST_HOME/bin:$GRADLE_HOME/bin:$PATH
        Hide
        oflebbe Olaf Flebbe added a comment -

        And thanks for noticing !

        Show
        oflebbe Olaf Flebbe added a comment - And thanks for noticing !
        Hide
        warwithin YoungWoo Kim added a comment -

        I get it. Let me revise the patch. Thanks!

        Show
        warwithin YoungWoo Kim added a comment - I get it. Let me revise the patch. Thanks!
        Hide
        warwithin YoungWoo Kim added a comment -

        BIGTOP-1793.2.patch:

        • Remove JAVA_HOME from the PATH
        Show
        warwithin YoungWoo Kim added a comment - BIGTOP-1793.2.patch : Remove JAVA_HOME from the PATH
        Hide
        oflebbe Olaf Flebbe added a comment -

        Thanks YoungWoo Kim! LGTM: +1, will commit.

        Show
        oflebbe Olaf Flebbe added a comment - Thanks YoungWoo Kim ! LGTM: +1, will commit.

          People

          • Assignee:
            warwithin YoungWoo Kim
            Reporter:
            warwithin YoungWoo Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development