Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0
    • Component/s: hive
    • Labels:
      None

      Description

      Just a reminder

      1. BIGTOP-1660.1.patch
        11 kB
        YoungWoo Kim
      2. BIGTOP-1660.2.patch
        10 kB
        YoungWoo Kim
      3. BIGTOP-1660.3.patch
        11 kB
        YoungWoo Kim
      4. BIGTOP-1660.4.patch
        11 kB
        YoungWoo Kim
      5. BIGTOP-1660.5.patch
        14 kB
        YoungWoo Kim
      6. BIGTOP-1660.6.patch
        15 kB
        YoungWoo Kim

        Issue Links

          Activity

          Hide
          oflebbe Olaf Flebbe added a comment -

          Committed! Thank you very much YoungWoo Kim !

          Show
          oflebbe Olaf Flebbe added a comment - Committed! Thank you very much YoungWoo Kim !
          Hide
          oflebbe Olaf Flebbe added a comment -

          LVGTM: Going to commit.

          Show
          oflebbe Olaf Flebbe added a comment - LVGTM: Going to commit.
          Hide
          warwithin YoungWoo Kim added a comment -

          Revised patch, BIGTOP-1660.6.patch: Addressed Olaf Flebbe's review comment.

          Show
          warwithin YoungWoo Kim added a comment - Revised patch, BIGTOP-1660.6.patch : Addressed Olaf Flebbe 's review comment.
          Hide
          oflebbe Olaf Flebbe added a comment - - edited

          YoungWoo Kim Sorry I was totally overcommitted last days.

          Now I tried rebuilding the source RPM: bigtop.bom is missing .
          Please add a Source18: bigtop.bom to spec file

          Furthermore please upgrade Standards-Version in deb/hive/control to 3.9.4 and
          compat to 9 (compare with tez for instance): This fixes one of the lintian messages.

          And last but not least: a ++1 !

          Show
          oflebbe Olaf Flebbe added a comment - - edited YoungWoo Kim Sorry I was totally overcommitted last days. Now I tried rebuilding the source RPM: bigtop.bom is missing . Please add a Source18: bigtop.bom to spec file Furthermore please upgrade Standards-Version in deb/hive/control to 3.9.4 and compat to 9 (compare with tez for instance): This fixes one of the lintian messages. And last but not least: a ++1 !
          Hide
          warwithin YoungWoo Kim added a comment -

          BIGTOP-1660.5.patch:

          • Remove Windows files (*.cmd)
          • Remove obsolete HBASE_STORAGE_HANDLER_DIR
          • Fix the duplicated symlink. Now, a symlink for standanlone jdbc jar is not created.
          • Add 'python' as a dependency for Deb.

          Olaf Flebbe Ping! Attached a patch, addressed your review comment. Thanks!

          Show
          warwithin YoungWoo Kim added a comment - BIGTOP-1660.5.patch : Remove Windows files (*.cmd) Remove obsolete HBASE_STORAGE_HANDLER_DIR Fix the duplicated symlink. Now, a symlink for standanlone jdbc jar is not created. Add 'python' as a dependency for Deb. Olaf Flebbe Ping! Attached a patch, addressed your review comment. Thanks!
          Hide
          warwithin YoungWoo Kim added a comment -

          Thanks for your detailed comment Olaf Flebbe and Sorry for the inconvenience.

          Will update a revised patch.

          Show
          warwithin YoungWoo Kim added a comment - Thanks for your detailed comment Olaf Flebbe and Sorry for the inconvenience. Will update a revised patch.
          Hide
          oflebbe Olaf Flebbe added a comment -

          Great work to begin cleaning up hive.

          Diagnostics I found while compiling on debian:

          Maybe all the Windows CMD scripts should be removed from hive and hive-hcatalog

          -rwxr-xr-x root/root      1381 2015-01-30 01:45 ./usr/lib/hive/bin/ext/jar.cmd
          -rwxr-xr-x root/root      1134 2015-01-30 01:45 ./usr/lib/hive/bin/ext/cli.cmd
          -rwxr-xr-x root/root      1769 2015-01-30 01:45 ./usr/lib/hive/bin/ext/hiveserver.cmd
          -rwxr-xr-x root/root      1777 2015-01-30 01:45 ./usr/lib/hive/bin/ext/metastore.cmd
          -rwxr-xr-x root/root      1923 2015-01-30 01:45 ./usr/lib/hive/bin/ext/hwi.cmd
          -rwxr-xr-x root/root      1215 2015-01-30 01:45 ./usr/lib/hive/bin/ext/rcfilecat.cmd
          -rwxr-xr-x root/root      1138 2015-01-30 01:45 ./usr/lib/hive/bin/ext/lineage.cmd
          -rwxr-xr-x root/root      1417 2015-01-30 01:45 ./usr/lib/hive/bin/ext/help.cmd
          -rwxr-xr-x root/root      3209 2015-01-30 01:45 ./usr/lib/hive/bin/ext/debug.cmd
          -rwxr-xr-x root/root      3159 2015-01-30 01:45 ./usr/lib/hive/bin/ext/hiveserver2.cmd
          -rwxr-xr-x root/root      1078 2015-01-30 01:45 ./usr/lib/hive/bin/ext/util/execHiveCmd.cmd
          -rwxr-xr-x root/root      1226 2015-01-30 01:45 ./usr/lib/hive/bin/ext/orcfiledump.cmd
          -rwxr-xr-x root/root      1213 2015-01-30 01:45 ./usr/lib/hive/bin/ext/schemaTool.cmd
          

          and

          -rwxr-xr-x root/root      3181 2015-01-30 01:45 ./usr/lib/hive-hcatalog/bin/templeton.cmd
          

          within hive_install.sh

          • the directory HBASE_STORAGE_HANDLER_DIR does not exist. I Get a error (translated)
            debian/install_hive.sh: line 250: cd: debian/tmp/usr/lib/hive-hcatalog/share/hcatalog/storage-handlers/hbase/lib: file not found
            
          • The symlink to hive-jdbc.jar exists file already exists.

          Debian Specific:
          Missing python dependency on hive-hcatalog and hive (contains python code).

          Show
          oflebbe Olaf Flebbe added a comment - Great work to begin cleaning up hive. Diagnostics I found while compiling on debian: Maybe all the Windows CMD scripts should be removed from hive and hive-hcatalog -rwxr-xr-x root/root 1381 2015-01-30 01:45 ./usr/lib/hive/bin/ext/jar.cmd -rwxr-xr-x root/root 1134 2015-01-30 01:45 ./usr/lib/hive/bin/ext/cli.cmd -rwxr-xr-x root/root 1769 2015-01-30 01:45 ./usr/lib/hive/bin/ext/hiveserver.cmd -rwxr-xr-x root/root 1777 2015-01-30 01:45 ./usr/lib/hive/bin/ext/metastore.cmd -rwxr-xr-x root/root 1923 2015-01-30 01:45 ./usr/lib/hive/bin/ext/hwi.cmd -rwxr-xr-x root/root 1215 2015-01-30 01:45 ./usr/lib/hive/bin/ext/rcfilecat.cmd -rwxr-xr-x root/root 1138 2015-01-30 01:45 ./usr/lib/hive/bin/ext/lineage.cmd -rwxr-xr-x root/root 1417 2015-01-30 01:45 ./usr/lib/hive/bin/ext/help.cmd -rwxr-xr-x root/root 3209 2015-01-30 01:45 ./usr/lib/hive/bin/ext/debug.cmd -rwxr-xr-x root/root 3159 2015-01-30 01:45 ./usr/lib/hive/bin/ext/hiveserver2.cmd -rwxr-xr-x root/root 1078 2015-01-30 01:45 ./usr/lib/hive/bin/ext/util/execHiveCmd.cmd -rwxr-xr-x root/root 1226 2015-01-30 01:45 ./usr/lib/hive/bin/ext/orcfiledump.cmd -rwxr-xr-x root/root 1213 2015-01-30 01:45 ./usr/lib/hive/bin/ext/schemaTool.cmd and -rwxr-xr-x root/root 3181 2015-01-30 01:45 ./usr/lib/hive-hcatalog/bin/templeton.cmd within hive_install.sh the directory HBASE_STORAGE_HANDLER_DIR does not exist. I Get a error (translated) debian/install_hive.sh: line 250: cd: debian/tmp/usr/lib/hive-hcatalog/share/hcatalog/storage-handlers/hbase/lib: file not found The symlink to hive-jdbc.jar exists file already exists. Debian Specific: Missing python dependency on hive-hcatalog and hive (contains python code).
          Hide
          warwithin YoungWoo Kim added a comment -
          Show
          warwithin YoungWoo Kim added a comment - BIGTOP-1660.4.patch
          Hide
          oflebbe Olaf Flebbe added a comment -

          Tested build of Patch.3 on DEB. Worked.

          Show
          oflebbe Olaf Flebbe added a comment - Tested build of Patch.3 on DEB. Worked.
          Hide
          warwithin YoungWoo Kim added a comment -

          Updated patch, BIGTOP-1660.2.patch

          Show
          warwithin YoungWoo Kim added a comment - Updated patch, BIGTOP-1660.2.patch
          Hide
          warwithin YoungWoo Kim added a comment -

          Attached patch, BIGTOP-1660.1.patch It's a WIP patch!

          • Bump up Hive verion to 1.0.0
          • Subpackage hive-server is removed.
          Show
          warwithin YoungWoo Kim added a comment - Attached patch, BIGTOP-1660.1.patch It's a WIP patch! Bump up Hive verion to 1.0.0 Subpackage hive-server is removed.

            People

            • Assignee:
              warwithin YoungWoo Kim
              Reporter:
              oflebbe Olaf Flebbe
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development