Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: build
    • Labels:
      None

      Description

      The bigtop toolchain is used for installing compile time dependencies and for deployment time dependencies (for instance in vagrant_puppet-docker)

      Prior this patch there is no destinction between runtime and compile time.

      Runtime and Development Packages are now separated. The interfaces ::installer and ::gradle have been left in place.

      Advantage of seperation that we can now include bulky packages like asciidoc into development which are not needed at run time. docker images should be small this way.

      So all the packages needed to recompile hue are now in place

        Activity

        Hide
        oflebbe Olaf Flebbe added a comment -

        Patch. Please Review

        Show
        oflebbe Olaf Flebbe added a comment - Patch. Please Review
        Hide
        rvs Roman Shaposhnik added a comment -

        Sorry for missing it the first time around, but I am confused. bigtop_toolchain was supposed to be all about build-time dependencies of packages. What kind of runtime are talking about here?

        Show
        rvs Roman Shaposhnik added a comment - Sorry for missing it the first time around, but I am confused. bigtop_toolchain was supposed to be all about build-time dependencies of packages. What kind of runtime are talking about here?
        Hide
        oflebbe Olaf Flebbe added a comment -

        I am talking about these:

        grep -r bigtop_toolchain bigtop-deploy/
        bigtop-deploy/vm/utils/setup-env-debian.sh:cd /bigtop-home && puppet apply --modulepath=./ -e "include bigtop_toolchain::gradle" # alias gradle=/usr/local/gradle/bin/gradle
        bigtop-deploy/vm/utils/setup-env-centos.sh:cd /bigtop-home && puppet apply --modulepath=./ -e "include bigtop_toolchain::gradle" # alias gradle=/usr/local/gradle/bin/gradle
        
        Show
        oflebbe Olaf Flebbe added a comment - I am talking about these: grep -r bigtop_toolchain bigtop-deploy/ bigtop-deploy/vm/utils/setup-env-debian.sh:cd /bigtop-home && puppet apply --modulepath=./ -e "include bigtop_toolchain::gradle" # alias gradle=/usr/local/gradle/bin/gradle bigtop-deploy/vm/utils/setup-env-centos.sh:cd /bigtop-home && puppet apply --modulepath=./ -e "include bigtop_toolchain::gradle" # alias gradle=/usr/local/gradle/bin/gradle
        Hide
        cos Konstantin Boudnik added a comment -

        But gradle isn't a runtime dep - it's precisely a build time dependency. Am I missing anything?

        Show
        cos Konstantin Boudnik added a comment - But gradle isn't a runtime dep - it's precisely a build time dependency. Am I missing anything?
        Hide
        cos Konstantin Boudnik added a comment -

        Also, things like
        - subscribe => Exec["/usr/bin/wget $bigtop_toolchain::deps::apache_prefix/ant/binaries/apache-ant-1.9.4-bin.tar.gz"], were added to calculate $bigtop_toolchain::deps::apache_prefix using best ASF mirror. Does it have to be removed?

        Show
        cos Konstantin Boudnik added a comment - Also, things like - subscribe => Exec ["/usr/bin/wget $bigtop_toolchain::deps::apache_prefix/ant/binaries/apache-ant-1.9.4-bin.tar.gz"] , were added to calculate $bigtop_toolchain::deps::apache_prefix using best ASF mirror. Does it have to be removed?
        Hide
        oflebbe Olaf Flebbe added a comment - - edited

        We have to ask Evans Ye| and jay vyas why they target gradle in their deploy scripts at all. Not clear to me too, now that you ask.

        Show
        oflebbe Olaf Flebbe added a comment - - edited We have to ask Evans Ye | and jay vyas why they target gradle in their deploy scripts at all. Not clear to me too, now that you ask.
        Hide
        evans_ye Evans Ye added a comment - - edited

        I've confirmed this with jay vyas: the gradle wrapper can be used to run the smoke tests, so we should remove the gradle installation in those setup-env.sh. Actually I did this in the patch of BIGTOP-1627.

        Show
        evans_ye Evans Ye added a comment - - edited I've confirmed this with jay vyas : the gradle wrapper can be used to run the smoke tests, so we should remove the gradle installation in those setup-env.sh. Actually I did this in the patch of BIGTOP-1627 .
        Hide
        oflebbe Olaf Flebbe added a comment -

        Ok, I have to rework it to include ascii doc only

        Show
        oflebbe Olaf Flebbe added a comment - Ok, I have to rework it to include ascii doc only
        Hide
        oflebbe Olaf Flebbe added a comment -

        There is no point in restructure the code this way, if gradle is to be removed from the deploy scripts in BIGTOP-1627.

        I withdraw this Ticket as WONTFIX.

        Thanks to Konstantin Boudnik and Roman Shaposhnik for looking into it and questioning the whole thing.

        Show
        oflebbe Olaf Flebbe added a comment - There is no point in restructure the code this way, if gradle is to be removed from the deploy scripts in BIGTOP-1627 . I withdraw this Ticket as WONTFIX. Thanks to Konstantin Boudnik and Roman Shaposhnik for looking into it and questioning the whole thing.
        Hide
        cos Konstantin Boudnik added a comment -

        You can count on it, Olaf

        Show
        cos Konstantin Boudnik added a comment - You can count on it, Olaf

          People

          • Assignee:
            oflebbe Olaf Flebbe
            Reporter:
            oflebbe Olaf Flebbe
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development