Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1617

Make clean-up commands in TestCLI more specific

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: tests
    • Labels:
      None

      Description

      Currently, some of the tests in TestCLI clean up by deleting the entire user directory:

      <cleanup-commands>
      <command>-fs NAMENODE -rm -r /user/USER_NAME</command>
      </cleanup-commands>

      If this directory exists prior to running the test and contains something other than subdirectories created during the test, stuff that shouldn't be deleted by TestCLI might get thrown out. The clean-up commands should specify which subdirectories and/or files to delete.

      1. BIGTOP-1617.patch
        5 kB
        Dasha Boudnik

        Activity

        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        This patch includes testDFSCLI and testHDFSCLI. testHCFSCLI is experiencing some major problems for some reason: altering the clean-up commands is messing up several dozen tests, so I've excluded that test altogether (for now?).

        Show
        dasha.boudnik Dasha Boudnik added a comment - This patch includes testDFSCLI and testHDFSCLI. testHCFSCLI is experiencing some major problems for some reason: altering the clean-up commands is messing up several dozen tests, so I've excluded that test altogether (for now?).
        Hide
        cos Konstantin Boudnik added a comment -

        You mean "excluded" from the scope of the current ticket?

        Show
        cos Konstantin Boudnik added a comment - You mean "excluded" from the scope of the current ticket?
        Hide
        cos Konstantin Boudnik added a comment -

        Once the patch is ready for a review it makes sense to move the ticket to "Patch Available" state. For this - click "Submit patch" button.

        Show
        cos Konstantin Boudnik added a comment - Once the patch is ready for a review it makes sense to move the ticket to "Patch Available" state. For this - click "Submit patch" button.
        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        Yeah, sorry for not making that clearer. So basically this patch doesn't fix testHCFSCLI, just the other two. And gotcha, thanks!

        Show
        dasha.boudnik Dasha Boudnik added a comment - Yeah, sorry for not making that clearer. So basically this patch doesn't fix testHCFSCLI, just the other two. And gotcha, thanks!
        Hide
        cos Konstantin Boudnik added a comment -

        Yup, pretty straight forward. +1, please commit

        Show
        cos Konstantin Boudnik added a comment - Yup, pretty straight forward. +1, please commit
        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        Committed and pushed. Thanks!

        Show
        dasha.boudnik Dasha Boudnik added a comment - Committed and pushed. Thanks!

          People

          • Assignee:
            dasha.boudnik Dasha Boudnik
            Reporter:
            dasha.boudnik Dasha Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development