Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: tests
    • Labels:
      None

      Description

      Instead of converting Strings to the necessary types, initialize with the correct types right away.

      1. BIGTOP-1593.patch
        9 kB
        Dasha Boudnik
      2. BIGTOP-1593.patch
        8 kB
        Dasha Boudnik
      3. BIGTOP-1593.patch
        8 kB
        Dasha Boudnik
      4. BIGTOP-1593.patch
        7 kB
        Dasha Boudnik

        Activity

        Hide
        cos Konstantin Boudnik added a comment -

        Looks like you haven't include the part of the patch for FailureVars class to update the types of the class properties. They are still Strings although you have changed all the getters and setters.

        Show
        cos Konstantin Boudnik added a comment - Looks like you haven't include the part of the patch for FailureVars class to update the types of the class properties. They are still Strings although you have changed all the getters and setters.
        Hide
        cos Konstantin Boudnik added a comment -

        Also, as the patch is touching a couple of smoke tests - could you please run then again a cluster to make sure that the change doesn't break anything? Thanks!

        Show
        cos Konstantin Boudnik added a comment - Also, as the patch is touching a couple of smoke tests - could you please run then again a cluster to make sure that the change doesn't break anything? Thanks!
        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        Tests are passing.

        Show
        dasha.boudnik Dasha Boudnik added a comment - Tests are passing.
        Hide
        cos Konstantin Boudnik added a comment -

        looks like this

          public void setKillDuration(String killDuration) {
            this.killDuration = killDuration;
          }
        

        needs to be also refactored to use long instead of String.
        The rest of the patch looks ok. Please fix the above and I will commit it.

        Show
        cos Konstantin Boudnik added a comment - looks like this public void setKillDuration( String killDuration) { this .killDuration = killDuration; } needs to be also refactored to use long instead of String. The rest of the patch looks ok. Please fix the above and I will commit it.
        Hide
        cos Konstantin Boudnik added a comment -

        One other thing: you need to cast properties initialization to the correct types inside of loadProps method

        Show
        cos Konstantin Boudnik added a comment - One other thing: you need to cast properties initialization to the correct types inside of loadProps method
        Hide
        cos Konstantin Boudnik added a comment -

        Nice - looks good now.
        +1

        Show
        cos Konstantin Boudnik added a comment - Nice - looks good now. +1
        Hide
        cos Konstantin Boudnik added a comment -

        Committed and pushed. Thanks Dasha!

        Show
        cos Konstantin Boudnik added a comment - Committed and pushed. Thanks Dasha!

          People

          • Assignee:
            dasha.boudnik Dasha Boudnik
            Reporter:
            dasha.boudnik Dasha Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development