Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1554

bigtop-deploy/puppet/config/site.csv was wrongfully committed.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: deployment
    • Labels:
      None

      Description

      bigtop-deploy/puppet/config/site.csv has been wrongfully committed as a part of BIGTOP-1497 patch.

      jay vyas, could you please be more careful with reviews? Thanks!

        Activity

        Hide
        evans_ye Evans Ye added a comment -

        Yes. Thanks for spotlighting this. Definitely it's better to review and refine the doc to avoid confusing. Would you mind to file up a ticket for this first?

        Show
        evans_ye Evans Ye added a comment - Yes. Thanks for spotlighting this. Definitely it's better to review and refine the doc to avoid confusing. Would you mind to file up a ticket for this first?
        Hide
        tomzeng Tom Zeng added a comment -

        Thanks Evans, I figured that's the case as well by looking at the vagrant config yaml. We should update the README.md to remove those references to site.csv:

        grep -r site.csv .

        ./bigtop-deploy/puppet/README.md:For example: If you have `site.csv` in `/etc/puppet/config`,
        ./bigtop-deploy/vm/vagrant-puppet-docker/README.md:See `bigtop-deploy/puppet/config/site.csv.example` for more details.
        ./bigtop-deploy/vm/vagrant-puppet-vm/README.md:See `bigtop-deploy/puppet/config/site.csv.example` for more details.
        ./pom.xml: <exclude>bigtop-deploy/puppet/config/site.csv.example</exclude>

        Show
        tomzeng Tom Zeng added a comment - Thanks Evans, I figured that's the case as well by looking at the vagrant config yaml. We should update the README.md to remove those references to site.csv: grep -r site.csv . ./bigtop-deploy/puppet/README.md:For example: If you have `site.csv` in `/etc/puppet/config`, ./bigtop-deploy/vm/vagrant-puppet-docker/README.md:See `bigtop-deploy/puppet/config/site.csv.example` for more details. ./bigtop-deploy/vm/vagrant-puppet-vm/README.md:See `bigtop-deploy/puppet/config/site.csv.example` for more details. ./pom.xml: <exclude>bigtop-deploy/puppet/config/site.csv.example</exclude>
        Hide
        evans_ye Evans Ye added a comment -

        Since BIGTOP-1634, bigtop puppet shifted to hiera. The site.csv is no longer needed. Instead, you can add/override configurations in site.yaml. You can find more in the updated README.

        Show
        evans_ye Evans Ye added a comment - Since BIGTOP-1634 , bigtop puppet shifted to hiera. The site.csv is no longer needed. Instead, you can add/override configurations in site.yaml. You can find more in the updated README .
        Hide
        tomzeng Tom Zeng added a comment -

        Is site.csv no longer needed? I don't see a site.csv.example either

        Show
        tomzeng Tom Zeng added a comment - Is site.csv no longer needed? I don't see a site.csv.example either
        Hide
        jayunit100 jay vyas added a comment -

        Konstantin Boudnik Good catch on this. Sorry about that , will be more careful esp on these big patches.

        Show
        jayunit100 jay vyas added a comment - Konstantin Boudnik Good catch on this. Sorry about that , will be more careful esp on these big patches.
        Hide
        cos Konstantin Boudnik added a comment -

        A trivial change - I have committed it without a review, as it was affecting my clusters deployment.

        Show
        cos Konstantin Boudnik added a comment - A trivial change - I have committed it without a review, as it was affecting my clusters deployment.

          People

          • Assignee:
            cos Konstantin Boudnik
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development