Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1459

Remove hadoop-client jar from packages that bundle it

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: debian, rpm
    • Labels:

      Description

      hadoop-client.jar contains no code and is merely an artifact of transitive dependencies that other components (like oozie) rely on it for.

      It makes sense to remove hadoop-client.jar from any packages that bundle it.

      See BIGTOP-1452 for more details.

      1. BIGTOP-1459.patch
        0.5 kB
        Newton Alex
      2. BIGTOP-1459.v2.patch
        0.6 kB
        Newton Alex
      3. BIGTOP-1459.v3.patch
        1 kB
        Newton Alex
      4. BIGTOP-1459.v4.patch
        0.9 kB
        Newton Alex

        Activity

        Hide
        nalex Newton Alex added a comment -

        Patch attached.

        Show
        nalex Newton Alex added a comment - Patch attached.
        Hide
        nalex Newton Alex added a comment -

        Patch Available

        Show
        nalex Newton Alex added a comment - Patch Available
        Hide
        mgrover Mark Grover added a comment -

        Thanks Alex. This only changes the rpm side of things. I'd think, it's be better to update install_oozie.sh and explicitly remove the jar in question.

        Show
        mgrover Mark Grover added a comment - Thanks Alex. This only changes the rpm side of things. I'd think, it's be better to update install_oozie.sh and explicitly remove the jar in question.
        Hide
        rguo Guo Ruijing added a comment -

        Yes. We may change install_oozie.sh as:

        cp -R $

        {BUILD_DIR}/bin/oozie ${CLIENT_LIB_DIR}/bin
        cp -R ${BUILD_DIR}

        /lib $

        {CLIENT_LIB_DIR}
        +rm -rf ${CLIENT_LIB_DIR}

        /oozie-client-*.jar

        Show
        rguo Guo Ruijing added a comment - Yes. We may change install_oozie.sh as: cp -R $ {BUILD_DIR}/bin/oozie ${CLIENT_LIB_DIR}/bin cp -R ${BUILD_DIR} /lib $ {CLIENT_LIB_DIR} +rm -rf ${CLIENT_LIB_DIR} /oozie-client-*.jar
        Hide
        nalex Newton Alex added a comment -

        Mark Grover Sorry about the delay.
        Here is the patch for the install_oozie.sh

        Show
        nalex Newton Alex added a comment - Mark Grover Sorry about the delay. Here is the patch for the install_oozie.sh
        Hide
        mgrover Mark Grover added a comment -

        Thanks Alex. This is looking good. One more, rather minor thing. Can you please generate the patch using the instructions listed at https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute

        That would make my life much easier when committing it. Thanks again!

        Show
        mgrover Mark Grover added a comment - Thanks Alex. This is looking good. One more, rather minor thing. Can you please generate the patch using the instructions listed at https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute That would make my life much easier when committing it. Thanks again!
        Hide
        nalex Newton Alex added a comment -

        Mark Grover Sorry, I missed reading the guidelines earlier. I've attached the new patch here following the guidelines. Please try BIGTOP-1459.v3.patch

        Show
        nalex Newton Alex added a comment - Mark Grover Sorry, I missed reading the guidelines earlier. I've attached the new patch here following the guidelines. Please try BIGTOP-1459 .v3.patch
        Hide
        mgrover Mark Grover added a comment -

        Sorry again, but is the change to spec file necessary if you are changing the install_oozie.sh? I think, that may break the build actually since rpmbuild wouldn't be able to find that file to exclude.

        Show
        mgrover Mark Grover added a comment - Sorry again, but is the change to spec file necessary if you are changing the install_oozie.sh? I think, that may break the build actually since rpmbuild wouldn't be able to find that file to exclude.
        Hide
        rguo Guo Ruijing added a comment -

        The change to spec file is not necessary and BIGTOP-1459.v3.patch is self-contained.

        install_oozie.sh is to remove oozie-client-.jar. (just like we didn't build out oozie-client.jar)

        so that RPM spec and debian spec can call install_oozie.sh.

        Show
        rguo Guo Ruijing added a comment - The change to spec file is not necessary and BIGTOP-1459 .v3.patch is self-contained. install_oozie.sh is to remove oozie-client- .jar. (just like we didn't build out oozie-client .jar) so that RPM spec and debian spec can call install_oozie.sh.
        Hide
        nalex Newton Alex added a comment -

        I thought the exclude directive was harmless. But from the comments it looks like it is better to remove the exclude directive from the patch. Will update the patch and send a new one.

        Show
        nalex Newton Alex added a comment - I thought the exclude directive was harmless. But from the comments it looks like it is better to remove the exclude directive from the patch. Will update the patch and send a new one.
        Hide
        nalex Newton Alex added a comment -

        Here is the patch with only the install_oozie.sh file change.
        File: BIGTOP-1459.v4.patch

        Show
        nalex Newton Alex added a comment - Here is the patch with only the install_oozie.sh file change. File: BIGTOP-1459 .v4.patch
        Hide
        cos Konstantin Boudnik added a comment -

        Looks good to me. Are you ok with it Mark Grover ?

        Show
        cos Konstantin Boudnik added a comment - Looks good to me. Are you ok with it Mark Grover ?
        Hide
        mgrover Mark Grover added a comment -

        +1. Cos, I am travelling right now. If you would commit this, I'd much appreciate it, thanks! And, thanks for this, Alex!

        Show
        mgrover Mark Grover added a comment - +1. Cos, I am travelling right now. If you would commit this, I'd much appreciate it, thanks! And, thanks for this, Alex!
        Hide
        cos Konstantin Boudnik added a comment -

        Committed and pushed
        6ec6ceb..0b31139 HEAD -> master

        Thanks Newton!

        Show
        cos Konstantin Boudnik added a comment - Committed and pushed 6ec6ceb..0b31139 HEAD -> master Thanks Newton!

          People

          • Assignee:
            nalex Newton Alex
            Reporter:
            mgrover Mark Grover
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development