Bigtop
  1. Bigtop
  2. BIGTOP-1365

Updates to Puppet README, and main README.md

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: backlog
    • Component/s: deployment
    • Labels:
      None

      Description

      Time for a expanded as a general clean up of READMEs files as they can all use a few touch ups.

      ( Original motivation for this JIRA: Puppet readme Should indicate that puppet confdir is underneath --confdir, i.e. if you have site.csv in /etc/puppet/config, then you should use --confdir=/etc/puppet. Its a subtle but annoying error to trace . While we're at it another round of improvments to the README might be nice as well ).

        Activity

        Hide
        Konstantin Boudnik added a comment -

        Let's do it!

        Show
        Konstantin Boudnik added a comment - Let's do it!
        Hide
        jay vyas added a comment -

        And in the process, should we add some "notice(….)" statements ? Im in the process of debugging the question i just asked on the mailing list. And I'm using that as the way to print parameter values.

        In my case, puppet apply is failing because there is no value for "hadoop_namenode_host" , so the notice directives are really helpful.

        Im not a puppet expert so puppet folks could chime in on how to debug this stuff would be great ! otherwise ill hack a patch with some more debug in it, and we can evaluate it that way.

        Show
        jay vyas added a comment - And in the process, should we add some "notice(….)" statements ? Im in the process of debugging the question i just asked on the mailing list. And I'm using that as the way to print parameter values. In my case, puppet apply is failing because there is no value for "hadoop_namenode_host" , so the notice directives are really helpful. Im not a puppet expert so puppet folks could chime in on how to debug this stuff would be great ! otherwise ill hack a patch with some more debug in it, and we can evaluate it that way.
        Hide
        jay vyas added a comment -

        Okay this is actually a pretty important thing to note ! (probably its obvious to some folks … but)

        It turns out that we DONT support puppet 3.
        The current recipes WILL NOT WORK with puppet 3.

        I didn't realize that. But (at least one reason) is because puppet 3 requires fully qualified variable names.

        Whew that was a nasty bug to chase down.

        Show
        jay vyas added a comment - Okay this is actually a pretty important thing to note ! (probably its obvious to some folks … but) It turns out that we DONT support puppet 3. The current recipes WILL NOT WORK with puppet 3. I didn't realize that. But (at least one reason) is because puppet 3 requires fully qualified variable names. Whew that was a nasty bug to chase down.
        Hide
        Konstantin Boudnik added a comment -

        jay vyas, I thought you've read my replies to your emails to the user@ list.
        Yes, we don't support 3.x - this is a known fact and there's a work happening on that here BIGTOP-1047

        Show
        Konstantin Boudnik added a comment - jay vyas , I thought you've read my replies to your emails to the user@ list. Yes, we don't support 3.x - this is a known fact and there's a work happening on that here BIGTOP-1047
        Hide
        jay vyas added a comment -

        ha - yeah i just did. too late but, its okay - forced me to learn how puppet does thing.
        as some final notes for the README update:

        • we should note that jdk version is required - if theres no yum package installed, then the install fails +
        • state a specific puppet version thats required. appears to be puppet-2.7.23-1 from the vagrant recipes.
        Show
        jay vyas added a comment - ha - yeah i just did. too late but, its okay - forced me to learn how puppet does thing. as some final notes for the README update: we should note that jdk version is required - if theres no yum package installed, then the install fails + state a specific puppet version thats required. appears to be puppet-2.7.23-1 from the vagrant recipes.
        Hide
        Konstantin Boudnik added a comment -

        Good point on jdk. With Puppet version - I am pretty sure anything 2.7+ will do.

        Show
        Konstantin Boudnik added a comment - Good point on jdk. With Puppet version - I am pretty sure anything 2.7+ will do.
        Hide
        jay vyas added a comment - - edited

        And also, update to main README.md file in this patch (might as well update other READMEs as well) : We need to modify the line that said -f bigtop-tests/test-execution/smokes/package/pom.xml to remove package, and replace with hadoop

        Show
        jay vyas added a comment - - edited And also, update to main README.md file in this patch (might as well update other READMEs as well) : We need to modify the line that said -f bigtop-tests/test-execution/smokes/package/pom.xml to remove package , and replace with hadoop
        Hide
        Roman Shaposhnik added a comment -

        Agreed. Would love to see a patch for the README

        Show
        Roman Shaposhnik added a comment - Agreed. Would love to see a patch for the README
        Hide
        jay vyas added a comment -

        okay finally got aroudn to updating these .

        Show
        jay vyas added a comment - okay finally got aroudn to updating these .
        Hide
        jay vyas added a comment -

        one more note BIGTOP-1161 components[0]==undef needs to be explained (its a way to do backward compatibility so that if no components defined, all the stack gets installed)>

        Show
        jay vyas added a comment - one more note BIGTOP-1161 components [0] ==undef needs to be explained (its a way to do backward compatibility so that if no components defined, all the stack gets installed)>
        Hide
        Konstantin Boudnik added a comment -

        Jay, perhaps the explanation of the code should go in as a comment into the code, rather than an external README?

        Show
        Konstantin Boudnik added a comment - Jay, perhaps the explanation of the code should go in as a comment into the code , rather than an external README?
        Hide
        jay vyas added a comment -

        agreed

        Show
        jay vyas added a comment - agreed
        Hide
        jay vyas added a comment -

        sorry i accidentally reopened this. closing now

        Show
        jay vyas added a comment - sorry i accidentally reopened this. closing now

          People

          • Assignee:
            jay vyas
            Reporter:
            jay vyas
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 2m
              2m

                Development