Bigtop
  1. Bigtop
  2. BIGTOP-1344

spec files assume RPMs being built on Red Hat

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.0.0
    • Component/s: rpm
    • Labels:
      None
    • Environment:

      Amazon Linux

      Description

      It would appear the spec files have the locations of brp-compress, etc in the __os_install_post stanza are hard-coded with Red Hat paths. If you try to build RPMs on, for example, an Amazon AMI (and probably OEL as well), those programs are not located there.

        Activity

        Allen Wittenauer created issue -
        Hide
        Allen Wittenauer added a comment -

        I suspect just changing these to %{_rpmconfigdir} instead of hard coded paths is all that is needed.

        Show
        Allen Wittenauer added a comment - I suspect just changing these to %{_rpmconfigdir} instead of hard coded paths is all that is needed.
        Hide
        Allen Wittenauer added a comment -

        This patch replaces the hard-coded /usr/lib/redhat with %{_rpmconfigdir}.

        Show
        Allen Wittenauer added a comment - This patch replaces the hard-coded /usr/lib/redhat with %{_rpmconfigdir}.
        Allen Wittenauer made changes -
        Field Original Value New Value
        Attachment 0001-BIGTOP-1344-spec-files-assume-RPMs-being-built-on-Re.patch [ 12652064 ]
        Allen Wittenauer made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.8.0 [ 12324841 ]
        Hide
        Peter Linnell added a comment -

        Thanks Allen for the patch! Please give me 24 hours to evaluate it against SLES and others.

        That said, the patch looks sane and simple. A tentative +1

        Show
        Peter Linnell added a comment - Thanks Allen for the patch! Please give me 24 hours to evaluate it against SLES and others. That said, the patch looks sane and simple. A tentative +1
        Peter Linnell made changes -
        Assignee Peter Linnell [ plinnell ]
        Hide
        Roman Shaposhnik added a comment -

        Peter Linnell any chance you can cast yay/nay? Would appreciate knowing this week since time for Bigtop 0.8.0 is getting tight.

        Show
        Roman Shaposhnik added a comment - Peter Linnell any chance you can cast yay/nay? Would appreciate knowing this week since time for Bigtop 0.8.0 is getting tight.
        Hide
        Konstantin Boudnik added a comment -

        ping

        Show
        Konstantin Boudnik added a comment - ping
        Hide
        Konstantin Boudnik added a comment -

        Moving to 0.9.0 as it doesn't seem important enough considering was sitting here for a while.

        Show
        Konstantin Boudnik added a comment - Moving to 0.9.0 as it doesn't seem important enough considering was sitting here for a while.
        Konstantin Boudnik made changes -
        Fix Version/s 0.9.0 [ 12326836 ]
        Fix Version/s 0.8.0 [ 12324841 ]
        Hide
        Roman Shaposhnik added a comment -

        Guys, I would really appreciate if somebody can find cycles to test/commit this one – with the INFRA issues I'm personally out cycles right now

        Show
        Roman Shaposhnik added a comment - Guys, I would really appreciate if somebody can find cycles to test/commit this one – with the INFRA issues I'm personally out cycles right now
        Hide
        Peter Linnell added a comment -

        Looking at it now. Will test a build tonight.

        Show
        Peter Linnell added a comment - Looking at it now. Will test a build tonight.
        Hide
        Peter Linnell added a comment -

        %{_rpmconfigdir} is not going to work on SLES 11. It is not defined in the standard macros file

        It will work on later openSUSE releases and upcoming SLES 12.

        At least for SUSE and openSUSE %{_rpmconfigdir} is always /usr/lib/rpm

        So, this can be ifdef'd and defined in the spec files of each package.

        Show
        Peter Linnell added a comment - %{_rpmconfigdir} is not going to work on SLES 11. It is not defined in the standard macros file It will work on later openSUSE releases and upcoming SLES 12. At least for SUSE and openSUSE %{_rpmconfigdir} is always /usr/lib/rpm So, this can be ifdef'd and defined in the spec files of each package.
        Hide
        Konstantin Boudnik added a comment - - edited

        Allen Wittenauer Peter Linnell: are you still interested in finishing this up? There are comments that seem to be unanswered for a few months now.

        Show
        Konstantin Boudnik added a comment - - edited Allen Wittenauer Peter Linnell : are you still interested in finishing this up? There are comments that seem to be unanswered for a few months now.
        Hide
        Allen Wittenauer added a comment -

        I'll likely abandon this. Sorry. Thanks.

        Show
        Allen Wittenauer added a comment - I'll likely abandon this. Sorry. Thanks.
        Hide
        Peter Linnell added a comment -


        Sorry this one slipped through. Give me a day or so to re-review. Tomorrow is all day travel for me.

        Show
        Peter Linnell added a comment - Sorry this one slipped through. Give me a day or so to re-review. Tomorrow is all day travel for me.
        Konstantin Boudnik made changes -
        Fix Version/s 1.0.0 [ 12326837 ]
        Fix Version/s 0.9.0 [ 12326836 ]
        Hide
        Konstantin Boudnik added a comment -

        Peter Linnell - is it possible to wrap it up today/tomorrow? I want to cut-off the release branch.

        Show
        Konstantin Boudnik added a comment - Peter Linnell - is it possible to wrap it up today/tomorrow? I want to cut-off the release branch.
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3d 22h 16m 1 Allen Wittenauer 23/Jun/14 22:09

          People

          • Assignee:
            Peter Linnell
            Reporter:
            Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:

              Development