Bigtop
  1. Bigtop
  2. BIGTOP-1344

spec files assume RPMs being built on Red Hat

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.9.0
    • Component/s: rpm
    • Labels:
      None
    • Environment:

      Amazon Linux

      Description

      It would appear the spec files have the locations of brp-compress, etc in the __os_install_post stanza are hard-coded with Red Hat paths. If you try to build RPMs on, for example, an Amazon AMI (and probably OEL as well), those programs are not located there.

        Activity

        Hide
        Allen Wittenauer added a comment -

        I suspect just changing these to %{_rpmconfigdir} instead of hard coded paths is all that is needed.

        Show
        Allen Wittenauer added a comment - I suspect just changing these to %{_rpmconfigdir} instead of hard coded paths is all that is needed.
        Hide
        Allen Wittenauer added a comment -

        This patch replaces the hard-coded /usr/lib/redhat with %{_rpmconfigdir}.

        Show
        Allen Wittenauer added a comment - This patch replaces the hard-coded /usr/lib/redhat with %{_rpmconfigdir}.
        Hide
        Peter Linnell added a comment -

        Thanks Allen for the patch! Please give me 24 hours to evaluate it against SLES and others.

        That said, the patch looks sane and simple. A tentative +1

        Show
        Peter Linnell added a comment - Thanks Allen for the patch! Please give me 24 hours to evaluate it against SLES and others. That said, the patch looks sane and simple. A tentative +1
        Hide
        Roman Shaposhnik added a comment -

        Peter Linnell any chance you can cast yay/nay? Would appreciate knowing this week since time for Bigtop 0.8.0 is getting tight.

        Show
        Roman Shaposhnik added a comment - Peter Linnell any chance you can cast yay/nay? Would appreciate knowing this week since time for Bigtop 0.8.0 is getting tight.
        Hide
        Konstantin Boudnik added a comment -

        ping

        Show
        Konstantin Boudnik added a comment - ping
        Hide
        Konstantin Boudnik added a comment -

        Moving to 0.9.0 as it doesn't seem important enough considering was sitting here for a while.

        Show
        Konstantin Boudnik added a comment - Moving to 0.9.0 as it doesn't seem important enough considering was sitting here for a while.
        Hide
        Roman Shaposhnik added a comment -

        Guys, I would really appreciate if somebody can find cycles to test/commit this one – with the INFRA issues I'm personally out cycles right now

        Show
        Roman Shaposhnik added a comment - Guys, I would really appreciate if somebody can find cycles to test/commit this one – with the INFRA issues I'm personally out cycles right now
        Hide
        Peter Linnell added a comment -

        Looking at it now. Will test a build tonight.

        Show
        Peter Linnell added a comment - Looking at it now. Will test a build tonight.
        Hide
        Peter Linnell added a comment -

        %{_rpmconfigdir} is not going to work on SLES 11. It is not defined in the standard macros file

        It will work on later openSUSE releases and upcoming SLES 12.

        At least for SUSE and openSUSE %{_rpmconfigdir} is always /usr/lib/rpm

        So, this can be ifdef'd and defined in the spec files of each package.

        Show
        Peter Linnell added a comment - %{_rpmconfigdir} is not going to work on SLES 11. It is not defined in the standard macros file It will work on later openSUSE releases and upcoming SLES 12. At least for SUSE and openSUSE %{_rpmconfigdir} is always /usr/lib/rpm So, this can be ifdef'd and defined in the spec files of each package.

          People

          • Assignee:
            Peter Linnell
            Reporter:
            Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:

              Development