Bigtop
  1. Bigtop
  2. BIGTOP-1344

spec files assume RPMs being built on Red Hat

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.1.0
    • Component/s: rpm
    • Labels:
      None
    • Environment:

      Amazon Linux

      Description

      It would appear the spec files have the locations of brp-compress, etc in the __os_install_post stanza are hard-coded with Red Hat paths. If you try to build RPMs on, for example, an Amazon AMI (and probably OEL as well), those programs are not located there.

        Activity

        Hide
        Olaf Flebbe added a comment -

        Evans Ye Thanks for the review , committing

        Show
        Olaf Flebbe added a comment - Evans Ye Thanks for the review , committing
        Hide
        Evans Ye added a comment -

        OH, YES! You're absolutely right.
        +1. I've tested this. Thanks for correcting me.

        Show
        Evans Ye added a comment - OH, YES! You're absolutely right. +1. I've tested this. Thanks for correcting me.
        Hide
        Olaf Flebbe added a comment -

        Unfortunately no. /usr/lib/rpm/redhat should by replaced by %{_rpmconfigdir} .

        Show
        Olaf Flebbe added a comment - Unfortunately no. /usr/lib/rpm/redhat should by replaced by %{_rpmconfigdir } .
        Hide
        Evans Ye added a comment - - edited

        I see some files in our code base still have hard-coded path for this line of code:

        /usr/lib/rpm/brp-compress ; \
        

        .
        Those components are zookeeper, sqoop, sqoop2, giraph, kafka, oozie, etc.
        And some line hasn't been updated in the component you''ve edited:

        rpm/phoenix/SPECS/phoenix.spec:    /usr/lib/rpm/brp-python-bytecompile ; \
        

        To me any /usr/lib/rpm/ prefix should be replaced, is that correct?

        Show
        Evans Ye added a comment - - edited I see some files in our code base still have hard-coded path for this line of code: /usr/lib/rpm/brp-compress ; \ . Those components are zookeeper, sqoop, sqoop2, giraph, kafka, oozie, etc. And some line hasn't been updated in the component you''ve edited: rpm/phoenix/SPECS/phoenix.spec: /usr/lib/rpm/brp-python-bytecompile ; \ To me any /usr/lib/rpm/ prefix should be replaced, is that correct?
        Hide
        Olaf Flebbe added a comment -

        Evans Ye: I think this is patch is needed for running the CI with opensuse....

        Show
        Olaf Flebbe added a comment - Evans Ye : I think this is patch is needed for running the CI with opensuse....
        Hide
        Olaf Flebbe added a comment -

        Updated patch to git trunk.

        Tested on opensuse with hadoop-rpm

        Show
        Olaf Flebbe added a comment - Updated patch to git trunk. Tested on opensuse with hadoop-rpm
        Hide
        Konstantin Boudnik added a comment -

        Nothing is happening - moving to the next release.

        Show
        Konstantin Boudnik added a comment - Nothing is happening - moving to the next release.
        Hide
        Konstantin Boudnik added a comment -

        Peter Linnell - is it possible to wrap it up today/tomorrow? I want to cut-off the release branch.

        Show
        Konstantin Boudnik added a comment - Peter Linnell - is it possible to wrap it up today/tomorrow? I want to cut-off the release branch.
        Hide
        Peter Linnell added a comment -


        Sorry this one slipped through. Give me a day or so to re-review. Tomorrow is all day travel for me.

        Show
        Peter Linnell added a comment - Sorry this one slipped through. Give me a day or so to re-review. Tomorrow is all day travel for me.
        Hide
        Allen Wittenauer added a comment -

        I'll likely abandon this. Sorry. Thanks.

        Show
        Allen Wittenauer added a comment - I'll likely abandon this. Sorry. Thanks.
        Hide
        Konstantin Boudnik added a comment - - edited

        Allen Wittenauer Peter Linnell: are you still interested in finishing this up? There are comments that seem to be unanswered for a few months now.

        Show
        Konstantin Boudnik added a comment - - edited Allen Wittenauer Peter Linnell : are you still interested in finishing this up? There are comments that seem to be unanswered for a few months now.
        Hide
        Peter Linnell added a comment -

        %{_rpmconfigdir} is not going to work on SLES 11. It is not defined in the standard macros file

        It will work on later openSUSE releases and upcoming SLES 12.

        At least for SUSE and openSUSE %{_rpmconfigdir} is always /usr/lib/rpm

        So, this can be ifdef'd and defined in the spec files of each package.

        Show
        Peter Linnell added a comment - %{_rpmconfigdir} is not going to work on SLES 11. It is not defined in the standard macros file It will work on later openSUSE releases and upcoming SLES 12. At least for SUSE and openSUSE %{_rpmconfigdir} is always /usr/lib/rpm So, this can be ifdef'd and defined in the spec files of each package.
        Hide
        Peter Linnell added a comment -

        Looking at it now. Will test a build tonight.

        Show
        Peter Linnell added a comment - Looking at it now. Will test a build tonight.
        Hide
        Roman Shaposhnik added a comment -

        Guys, I would really appreciate if somebody can find cycles to test/commit this one – with the INFRA issues I'm personally out cycles right now

        Show
        Roman Shaposhnik added a comment - Guys, I would really appreciate if somebody can find cycles to test/commit this one – with the INFRA issues I'm personally out cycles right now
        Hide
        Konstantin Boudnik added a comment -

        Moving to 0.9.0 as it doesn't seem important enough considering was sitting here for a while.

        Show
        Konstantin Boudnik added a comment - Moving to 0.9.0 as it doesn't seem important enough considering was sitting here for a while.
        Hide
        Konstantin Boudnik added a comment -

        ping

        Show
        Konstantin Boudnik added a comment - ping
        Hide
        Roman Shaposhnik added a comment -

        Peter Linnell any chance you can cast yay/nay? Would appreciate knowing this week since time for Bigtop 0.8.0 is getting tight.

        Show
        Roman Shaposhnik added a comment - Peter Linnell any chance you can cast yay/nay? Would appreciate knowing this week since time for Bigtop 0.8.0 is getting tight.
        Hide
        Peter Linnell added a comment -

        Thanks Allen for the patch! Please give me 24 hours to evaluate it against SLES and others.

        That said, the patch looks sane and simple. A tentative +1

        Show
        Peter Linnell added a comment - Thanks Allen for the patch! Please give me 24 hours to evaluate it against SLES and others. That said, the patch looks sane and simple. A tentative +1
        Hide
        Allen Wittenauer added a comment -

        This patch replaces the hard-coded /usr/lib/redhat with %{_rpmconfigdir}.

        Show
        Allen Wittenauer added a comment - This patch replaces the hard-coded /usr/lib/redhat with %{_rpmconfigdir}.
        Hide
        Allen Wittenauer added a comment -

        I suspect just changing these to %{_rpmconfigdir} instead of hard coded paths is all that is needed.

        Show
        Allen Wittenauer added a comment - I suspect just changing these to %{_rpmconfigdir} instead of hard coded paths is all that is needed.

          People

          • Assignee:
            Olaf Flebbe
            Reporter:
            Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development