[BIGTOP-1316] enhance Shell for better checking of return code & output logging

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.8.0
• Fix Version/s: 0.8.0
• Component/s: tests
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 20/May/14 08:46
• Updated: 01/Jul/14 21:08
• Resolved: 01/Jul/14 18:23

Description

for the slider tests, we extended Shell with [SliderShellhttps://svn.apache.org/viewvc/incubator/slider/trunk/slider-funtest/src/main/groovy/org/apache/slider/funtest/framework/SliderShell.groovy?view=markup], adding some more features. Some of those are biased towards executing our entry point, but there are some useful core features worth pulling up to the base class

1. toString() and dump() methods with diagnostics
2. return code sign correction and assertion checking
3. construction of bash environment and command lines

The bash setup could be done with a class Bash extends Shell which is designed purely for bash execution

Issue Links

• is depended upon by: SLIDER-75 push back slider shell enhancements into bigtop