Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: backlog
    • Fix Version/s: None
    • Component/s: rpm
    • Labels:
      None

      Description

      This is sub-task of BIGTOP-1243,only add Vendor in RPM information

      existing behavior:

      $ rpm -qi bigtop-jsvc-1.0.10-1.el6.x86_64
      Version : 1.0.10 Vendor: (none)

      expected behavior:
      $ rpm -qi bigtop-jsvc-1.0.10-1.el6.x86_64
      Version : 1.0.10 Vendor: (Bigtop)

      1. BIGTOP-1251.2.patch
        14 kB
        Wenwu Peng
      2. BIGTOP-1251.1.patch
        14 kB
        Wenwu Peng

        Activity

        Wenwu Peng created issue -
        Hide
        Wenwu Peng added a comment -

        Attach the first version for review

        Show
        Wenwu Peng added a comment - Attach the first version for review
        Wenwu Peng made changes -
        Field Original Value New Value
        Attachment BIGTOP-1251.1.patch [ 12633871 ]
        Hide
        Guo Ruijing added a comment -

        There is a typo: Apahce Bigtop.
        expect: Apache Bigtop

        Show
        Guo Ruijing added a comment - There is a typo: Apahce Bigtop. expect: Apache Bigtop
        Hide
        Wenwu Peng added a comment -

        Thanks Ruijing review and comments, fix the typo issue.

        Show
        Wenwu Peng added a comment - Thanks Ruijing review and comments, fix the typo issue.
        Wenwu Peng made changes -
        Attachment BIGTOP-1251.2.patch [ 12633877 ]
        Hide
        Andrew Purtell added a comment -

        The changes to RPM specfiles look fine to me. I don't see any corresponding updates to Debian control files. Maybe you just overlooked those? Or was there some issue?

        Show
        Andrew Purtell added a comment - The changes to RPM specfiles look fine to me. I don't see any corresponding updates to Debian control files. Maybe you just overlooked those? Or was there some issue?
        Hide
        Wenwu Peng added a comment -

        Thanks a lot Andrew Purtell review and comments.
        google the debian control vendor http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Distribution
        and I found can't get useful info about vendor in debian. could you give some more tips about debian vendor info in package?

        Show
        Wenwu Peng added a comment - Thanks a lot Andrew Purtell review and comments. google the debian control vendor http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Distribution and I found can't get useful info about vendor in debian. could you give some more tips about debian vendor info in package?
        Hide
        Andrew Purtell added a comment -

        google the debian control vendor http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Distribution and I found can't get useful info about vendor in debian. could you give some more tips about debian vendor info in package?

        As proposer of this change wenwupeng, it's I think something you should investigate and provide a solution for. However maybe someone here with more familiarity about Debian packaging can provide some advice to you.

        Show
        Andrew Purtell added a comment - google the debian control vendor http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Distribution and I found can't get useful info about vendor in debian. could you give some more tips about debian vendor info in package? As proposer of this change wenwupeng , it's I think something you should investigate and provide a solution for. However maybe someone here with more familiarity about Debian packaging can provide some advice to you.
        Hide
        jun aoki added a comment -

        I'm no Debian package expert but I looked into a few well-known deb packages but could not find "vendor".
        "Maintainer" and "Original-Maintainer" are the closest?
        I'd imagine
        "Original-Maintainer" is always Apache Bigtop (of course it is depends on how vendors will or will not modify )
        "Maintainer" can be modified to distribution vendors.

        Package: vim
        Priority: optional
        Section: editors
        Installed-Size: 2149
        Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
        Original-Maintainer: Debian Vim Maintainers <pkg-vim-maintainers@lists.alioth.debian.org>
        Architecture: amd64
        Version: 2:7.4.000-1ubuntu2
        Provides: editor
        Depends: vim-common (= 2:7.4.000-1ubuntu2), vim-runtime (= 2:7.4.000-1ubuntu2), libacl1 (>= 2.2.51-8), libc6 (>= 2.15), libgpm2 (>= 1.20.4), libpython2.7 (>= 2.7), libselinux1 (>= 1.32), libtinfo5
        Suggests: ctags, vim-doc, vim-scripts
        Filename: pool/main/v/vim/vim_7.4.000-1ubuntu2_amd64.deb
        Size: 945150
        MD5sum: bb4d03351fc92573fda9330442e26e81
        SHA1: 76f49ebb6cecd28a67fec1f684e8b989dd79914b
        SHA256: 0f14852d1301fb79e31e64149d0747711b7b2852c649c0a46c197147e759f60a
        Description-en: Vi IMproved - enhanced vi editor
         Vim is an almost compatible version of the UNIX editor Vi.
         .
         Many new features have been added: multi level undo, syntax
         highlighting, command line history, on-line help, filename
         completion, block operations, folding, Unicode support, etc.
         .
         This package contains a version of vim compiled with a rather
         standard set of features.  This package does not provide a GUI
         version of Vim.  See the other vim-* packages if you need more
         (or less).
        Description-md5: 59e8b8f7757db8b53566d5d119872de8
        Homepage: http://www.vim.org/
        Description-md5: 59e8b8f7757db8b53566d5d119872de8
        Bugs: https://bugs.launchpad.net/ubuntu/+filebug
        Origin: Ubuntu
        Supported: 9m
        Task: ubuntu-usb, cloud-image, server, edubuntu-desktop-gnome, edubuntu-usb
        
        Package: compiz
        Priority: optional
        Section: x11
        Installed-Size: 112
        Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
        Original-Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
        Architecture: all
        Version: 1:0.9.10+13.10.20131011-0ubuntu1
        Provides: x-window-manager
        Depends: compiz-core (>= 1:0.9.10+13.10.20131011-0ubuntu1), compiz-plugins-default (>= 1:0.9.10+13.10.20131011-0ubuntu1), compiz-gnome, debconf (>= 0.5) | debconf-2.0
        Filename: pool/main/c/compiz/compiz_0.9.10+13.10.20131011-0ubuntu1_all.deb
        Size: 4110
        MD5sum: cd2f6674d46db0a68aa3f904844e7503
        SHA1: b096bec4016053c49b17275e8aca9ccd1d93356e
        SHA256: ae50a86fff1ce523b198c0a3c1635a893bbd70bcb5a241f8895ab22650966732
        Description-en: OpenGL window and compositing manager
         Compiz brings to life a variety of visual effects that make the Linux desktop
         easier to use, more powerful and intuitive, and more accessible for users
         with special needs.
         .
         This metapackage provides the components necessary for running compiz. It
         provides the compiz core, a set of standard plugins, a window decorator using
         the Gtk toolkit and the files necessary to integrate compiz with the GNOME
         desktop environment.
        Description-md5: f8949ff691855a5244d51aa54ee72f8f
        Bugs: https://bugs.launchpad.net/ubuntu/+filebug
        Origin: Ubuntu
        Supported: 9m
        Task: ubuntu-desktop, ubuntu-usb, edubuntu-desktop, edubuntu-usb
        
        Package: gnome
        Priority: optional
        Section: universe/gnome
        Installed-Size: 53
        Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
        Original-Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
        Architecture: amd64
        Source: meta-gnome3
        Version: 1:3.8+4ubuntu1
        Depends: gnome-core (= 1:3.8+4ubuntu1), desktop-base, network-manager-gnome (>= 0.9.4), aisleriot (>= 1:3.4), cheese (>= 3.4), evolution (>= 3.8), evolution-plugins (>= 3.8), file-roller (>= 3.4), gedit (>= 3.4), gnome-color-manager (>= 3.4), gnome-documents (>= 0.4), gnome-games (>= 1:3.4), gnome-nettool (>= 3.2), nautilus-sendto (>= 3.0), gnome-orca (>= 3.4), rygel-preferences (>= 0.14), seahorse (>= 3.4), totem (>= 3.0), vinagre (>= 3.4), alacarte (>= 0.13.4), avahi-daemon, gimp (>= 2.8), gnome-media (>= 3.4), gnome-tweak-tool (>= 3.4), hamster-applet (>= 2.91.3), inkscape (>= 0.48), libreoffice-gnome, libreoffice-writer | abiword (>= 2.8), libreoffice-calc | gnumeric (>= 1.10), libreoffice-impress, rhythmbox (>= 2.96), shotwell, simple-scan, sound-juicer (>= 3.4), tomboy (>= 1.10) | gnote, tracker-gui, transmission-gtk, xdg-user-dirs-gtk, cups-pk-helper (>= 0.2), gedit-plugins (>= 3.4), gnome-applets (>= 3.4), gnome-shell-extensions (>= 3.4), gstreamer1.0-libav (>= 0.10.13), gstreamer1.0-plugins-ugly (>= 0.10.19), rhythmbox-plugins, rhythmbox-plugin-cdrecorder, rygel-playbin, rygel-tracker | rygel, telepathy-gabble, telepathy-rakia, telepathy-salut, totem-plugins, libgtk2-perl (>= 1:1.130)
        Recommends: browser-plugin-gnash, gdebi, nautilus-sendto-empathy, telepathy-idle
        Suggests: dia-gnome, gnome-boxes, gnucash, libreoffice-evolution, planner
        Filename: pool/universe/m/meta-gnome3/gnome_3.8+4ubuntu1_amd64.deb
        Size: 2776
        MD5sum: 77b63e8899772c219f4cdefed7a8ebd0
        SHA1: 494647d234f906a48213a29f5b28eca8dd5f49e9
        SHA256: b02df7dfd6f2a468bb462430b5f03dc4f7a7b4a489f8efbeaa0c6af892a9cafe
        Description-en: Full GNOME Desktop Environment, with extra components
         This is the GNOME Desktop environment, an intuitive and attractive
         desktop, with extra components.
         .
         This meta-package depends on the standard distribution of the GNOME
         desktop environment, plus a complete range of plugins and other
         applications integrating with GNOME and Debian, providing the best
         possible environment to date.
        Description-md5: d4f5001bf7ac9eaab17c33045e06a375
        Bugs: https://bugs.launchpad.net/ubuntu/+filebug
        Origin: Ubuntu
        
        Show
        jun aoki added a comment - I'm no Debian package expert but I looked into a few well-known deb packages but could not find "vendor". "Maintainer" and "Original-Maintainer" are the closest? I'd imagine "Original-Maintainer" is always Apache Bigtop (of course it is depends on how vendors will or will not modify ) "Maintainer" can be modified to distribution vendors. Package: vim Priority: optional Section: editors Installed-Size: 2149 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com> Original-Maintainer: Debian Vim Maintainers <pkg-vim-maintainers@lists.alioth.debian.org> Architecture: amd64 Version: 2:7.4.000-1ubuntu2 Provides: editor Depends: vim-common (= 2:7.4.000-1ubuntu2), vim-runtime (= 2:7.4.000-1ubuntu2), libacl1 (>= 2.2.51-8), libc6 (>= 2.15), libgpm2 (>= 1.20.4), libpython2.7 (>= 2.7), libselinux1 (>= 1.32), libtinfo5 Suggests: ctags, vim-doc, vim-scripts Filename: pool/main/v/vim/vim_7.4.000-1ubuntu2_amd64.deb Size: 945150 MD5sum: bb4d03351fc92573fda9330442e26e81 SHA1: 76f49ebb6cecd28a67fec1f684e8b989dd79914b SHA256: 0f14852d1301fb79e31e64149d0747711b7b2852c649c0a46c197147e759f60a Description-en: Vi IMproved - enhanced vi editor Vim is an almost compatible version of the UNIX editor Vi. . Many new features have been added: multi level undo, syntax highlighting, command line history, on-line help, filename completion, block operations, folding, Unicode support, etc. . This package contains a version of vim compiled with a rather standard set of features. This package does not provide a GUI version of Vim. See the other vim-* packages if you need more (or less). Description-md5: 59e8b8f7757db8b53566d5d119872de8 Homepage: http: //www.vim.org/ Description-md5: 59e8b8f7757db8b53566d5d119872de8 Bugs: https: //bugs.launchpad.net/ubuntu/+filebug Origin: Ubuntu Supported: 9m Task: ubuntu-usb, cloud-image, server, edubuntu-desktop-gnome, edubuntu-usb Package: compiz Priority: optional Section: x11 Installed-Size: 112 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com> Original-Maintainer: Debian X Strike Force <debian-x@lists.debian.org> Architecture: all Version: 1:0.9.10+13.10.20131011-0ubuntu1 Provides: x-window-manager Depends: compiz-core (>= 1:0.9.10+13.10.20131011-0ubuntu1), compiz-plugins- default (>= 1:0.9.10+13.10.20131011-0ubuntu1), compiz-gnome, debconf (>= 0.5) | debconf-2.0 Filename: pool/main/c/compiz/compiz_0.9.10+13.10.20131011-0ubuntu1_all.deb Size: 4110 MD5sum: cd2f6674d46db0a68aa3f904844e7503 SHA1: b096bec4016053c49b17275e8aca9ccd1d93356e SHA256: ae50a86fff1ce523b198c0a3c1635a893bbd70bcb5a241f8895ab22650966732 Description-en: OpenGL window and compositing manager Compiz brings to life a variety of visual effects that make the Linux desktop easier to use, more powerful and intuitive, and more accessible for users with special needs. . This metapackage provides the components necessary for running compiz. It provides the compiz core, a set of standard plugins, a window decorator using the Gtk toolkit and the files necessary to integrate compiz with the GNOME desktop environment. Description-md5: f8949ff691855a5244d51aa54ee72f8f Bugs: https: //bugs.launchpad.net/ubuntu/+filebug Origin: Ubuntu Supported: 9m Task: ubuntu-desktop, ubuntu-usb, edubuntu-desktop, edubuntu-usb Package: gnome Priority: optional Section: universe/gnome Installed-Size: 53 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com> Original-Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org> Architecture: amd64 Source: meta-gnome3 Version: 1:3.8+4ubuntu1 Depends: gnome-core (= 1:3.8+4ubuntu1), desktop-base, network-manager-gnome (>= 0.9.4), aisleriot (>= 1:3.4), cheese (>= 3.4), evolution (>= 3.8), evolution-plugins (>= 3.8), file-roller (>= 3.4), gedit (>= 3.4), gnome-color-manager (>= 3.4), gnome-documents (>= 0.4), gnome-games (>= 1:3.4), gnome-nettool (>= 3.2), nautilus-sendto (>= 3.0), gnome-orca (>= 3.4), rygel-preferences (>= 0.14), seahorse (>= 3.4), totem (>= 3.0), vinagre (>= 3.4), alacarte (>= 0.13.4), avahi-daemon, gimp (>= 2.8), gnome-media (>= 3.4), gnome-tweak-tool (>= 3.4), hamster-applet (>= 2.91.3), inkscape (>= 0.48), libreoffice-gnome, libreoffice-writer | abiword (>= 2.8), libreoffice-calc | gnumeric (>= 1.10), libreoffice-impress, rhythmbox (>= 2.96), shotwell, simple-scan, sound-juicer (>= 3.4), tomboy (>= 1.10) | gnote, tracker-gui, transmission-gtk, xdg-user-dirs-gtk, cups-pk-helper (>= 0.2), gedit-plugins (>= 3.4), gnome-applets (>= 3.4), gnome-shell-extensions (>= 3.4), gstreamer1.0-libav (>= 0.10.13), gstreamer1.0-plugins-ugly (>= 0.10.19), rhythmbox-plugins, rhythmbox-plugin-cdrecorder, rygel-playbin, rygel-tracker | rygel, telepathy-gabble, telepathy-rakia, telepathy-salut, totem-plugins, libgtk2-perl (>= 1:1.130) Recommends: browser-plugin-gnash, gdebi, nautilus-sendto-empathy, telepathy-idle Suggests: dia-gnome, gnome-boxes, gnucash, libreoffice-evolution, planner Filename: pool/universe/m/meta-gnome3/gnome_3.8+4ubuntu1_amd64.deb Size: 2776 MD5sum: 77b63e8899772c219f4cdefed7a8ebd0 SHA1: 494647d234f906a48213a29f5b28eca8dd5f49e9 SHA256: b02df7dfd6f2a468bb462430b5f03dc4f7a7b4a489f8efbeaa0c6af892a9cafe Description-en: Full GNOME Desktop Environment, with extra components This is the GNOME Desktop environment, an intuitive and attractive desktop, with extra components. . This meta- package depends on the standard distribution of the GNOME desktop environment, plus a complete range of plugins and other applications integrating with GNOME and Debian, providing the best possible environment to date. Description-md5: d4f5001bf7ac9eaab17c33045e06a375 Bugs: https: //bugs.launchpad.net/ubuntu/+filebug Origin: Ubuntu
        Hide
        Wenwu Peng added a comment -

        Thanks a lot for Andrew Purtell and jun aoki review and comments.
        actually, debian control fine have included the "Maintainer",

        Show
        Wenwu Peng added a comment - Thanks a lot for Andrew Purtell and jun aoki review and comments. actually, debian control fine have included the "Maintainer",
        Hide
        Shengjun Xin added a comment -

        +1, looks good to me

        Show
        Shengjun Xin added a comment - +1, looks good to me
        Hide
        Roman Shaposhnik added a comment -

        Would you guys feel comfortable making the DEBIAN file flexible as well? Right now Maintainer is hardcoded, we probably need to pull the same trick there as you're pulling on the RPM side with variable substitutions: https://www.debian.org/doc/debian-policy/ch-source.html#s-substvars

        Show
        Roman Shaposhnik added a comment - Would you guys feel comfortable making the DEBIAN file flexible as well? Right now Maintainer is hardcoded, we probably need to pull the same trick there as you're pulling on the RPM side with variable substitutions: https://www.debian.org/doc/debian-policy/ch-source.html#s-substvars
        Hide
        Wenwu Peng added a comment -

        Thanks Roman Shaposhnik review and comments.

        is it OK we replace with $(VENDOR) $(MAIL) by sed in package.mk? and $(VENDOR) $(MAIL) defined in bigtop.mk
        if yes, I will update the patches.

        (echo e "$($(PKG)_PKG_NAME) ($(PKG_PKG_VERSION)$(BIGTOP_BUILD_STAMP)$($(PKG)_RELEASE)) stable; urgency=low\n" && \
        echo " Clean build" && \
        echo " – Bigtop <dev@bigtop.apache.org> "`date +'%a, %d %b %Y %T %z'`) > debian/changelog && \
        sed -i -e "s/Maintainer: Bigtop <dev@bigtop.apache.org>/Maintainer:$(VENDOR) $(MAIL)/g" debian/control && \

        Show
        Wenwu Peng added a comment - Thanks Roman Shaposhnik review and comments. is it OK we replace with $(VENDOR) $(MAIL) by sed in package.mk? and $(VENDOR) $(MAIL) defined in bigtop.mk if yes, I will update the patches. (echo e "$($(PKG)_PKG_NAME) ($(PKG_PKG_VERSION)$(BIGTOP_BUILD_STAMP) $($(PKG)_RELEASE)) stable; urgency=low\n" && \ echo " Clean build" && \ echo " – Bigtop <dev@bigtop.apache.org> "`date +'%a, %d %b %Y %T %z'`) > debian/changelog && \ sed -i -e "s/Maintainer: Bigtop <dev@bigtop.apache.org>/Maintainer:$(VENDOR) $(MAIL)/g" debian/control && \
        Hide
        Roman Shaposhnik added a comment -

        I don't think sed is ok. Please follow the link with documentation on how to use variables in Debian files I've mentioned in my prior comment.

        Show
        Roman Shaposhnik added a comment - I don't think sed is ok. Please follow the link with documentation on how to use variables in Debian files I've mentioned in my prior comment.
        Hide
        Wenwu Peng added a comment - - edited

        I full agree with Roman, sed not a good chooice.I split the Debian variables Maintainer to other jira BIGTOP-1264 for more discussion due to RPM and debian have different variable substitutions mechanism, I will provide the pathes for review in next days in BIGTOP-1264.

        Show
        Wenwu Peng added a comment - - edited I full agree with Roman, sed not a good chooice.I split the Debian variables Maintainer to other jira BIGTOP-1264 for more discussion due to RPM and debian have different variable substitutions mechanism, I will provide the pathes for review in next days in BIGTOP-1264 .

          People

          • Assignee:
            Wenwu Peng
            Reporter:
            Wenwu Peng
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:

              Development