There's a couple of ways to reproduce the issue:
% make realclean
% make bigtop-groovy-rpm
## zip file is getting downloaded and everything builds fine
## there are dl/groovy-binary-2.2.1.tar.gz.orig (zip format) and dl/groovy-binary-2.2.1.tar.gz (tar.gz)
% make clean bigtop-groovy-rpm
## fails as unzip fails now
Exactly same behavior is observable in case of deb creation. So, there are some extra file movements happening around the zip file, that are screwing up the setup.
The patch in current form works if I manually delete dl/groovy*. It triggers re-downloading of the zip archive and process is moving forward just fine. Perhaps, this is an acceptable first iteration of the patch and it unblocks
BIGTOP-1097 for now. However, we should fix it sooner than later, because the build process will now inadvertently require a real clean process in between of the runs.
I am ok with +1'ing this patch, committing it, and opening a separate bug issue to fix the glitch, if this is something we want to do to unblock the progress on groovy-package JIRA.