Bigtop
  1. Bigtop
  2. BIGTOP-1071

bigtop-detect-javahome should select the first possible candidate in the list

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Though the intent of the script seems to be "prefering Oracle JDK to OpenJDK and prefering JDK 6 to JDK 7", current implementation select the last possible candidate in the list if multiple JDKs are installed.

      1. BIGTOP-1071-0.patch
        0.6 kB
        Masatake Iwasaki
      2. BIGTOP-1071-2.patch
        0.6 kB
        Masatake Iwasaki

        Activity

        Hide
        Sean Mackrory added a comment -

        Recommitted, and repushed. Also actually tried running a service script to be extra-sure Thanks!

        Show
        Sean Mackrory added a comment - Recommitted, and repushed. Also actually tried running a service script to be extra-sure Thanks!
        Hide
        Masatake Iwasaki added a comment -

        attaching fixed patch.

        Show
        Masatake Iwasaki added a comment - attaching fixed patch.
        Hide
        Masatake Iwasaki added a comment -

        I am sorry but the patch has problem for service scripts. It should not exit but return.

        Show
        Masatake Iwasaki added a comment - I am sorry but the patch has problem for service scripts. It should not exit but return.
        Hide
        Sean Mackrory added a comment -

        I misspoke - it was BIGTOP-1069 that was already committed. I have now committed and pushed this patch.

        Show
        Sean Mackrory added a comment - I misspoke - it was BIGTOP-1069 that was already committed. I have now committed and pushed this patch.
        Hide
        Sean Mackrory added a comment -

        +1 - although it appears Konstantin Boudnik has already committed this. The addition of the nested loop is quite recent - and I guess the need to switch from break to exit was just omitted at that time.

        Thank you very much for the patch!

        Show
        Sean Mackrory added a comment - +1 - although it appears Konstantin Boudnik has already committed this. The addition of the nested loop is quite recent - and I guess the need to switch from break to exit was just omitted at that time. Thank you very much for the patch!
        Hide
        Masatake Iwasaki added a comment -

        attaching the patch.

        Show
        Masatake Iwasaki added a comment - attaching the patch.

          People

          • Assignee:
            Masatake Iwasaki
            Reporter:
            Masatake Iwasaki
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development