[BIGTOP-1011] bigtop-detect-javahome has a quirky search order

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.7.0
• Assignee: Sean Mackrory
• Reporter: Jolly Chen
• Created: 12/Jun/13 21:39
• Updated: 04/Nov/13 21:24
• Resolved: 12/Jul/13 21:04

Description

If JAVA_HOME is not set, bigtop-detect-javahome has a very quirky search order that can have surprising behavior.

Some problems:

• because the "defaults" (like /usr/java/default, /usr/lib/jvm/default-java, /Library/Java/Home) are in the middle of the search list, bigtop will pick up other random JDKs instead of the 'default' the user already has set up on the system.
• due to use of wildcards, earlier minor versions can be preferred over later minor versions, e.g. /usr/java/jdk1.6* will find 1.6.0_31 before 1.6.0_43, which is probably not what the user wants.
• 1.6 and 1.7 preference order is not consistent (e.g. generally 1.6 is preferred over 1.7 but not for openJDK)

This is related to previous issue: https://issues.apache.org/jira/browse/BIGTOP-843

1. attempt to find java
   if [ -z "$JAVA_HOME" ]; then
   for candidate in \
   /usr/lib/j2sdk1.6-sun \
   /usr/lib/jvm/java-6-sun \
   /usr/lib/jvm/java-1.6.0-sun-1.6.0.* \
   /usr/lib/jvm/java-1.6.0-sun-1.6.0.*/jre/ \
   /usr/lib/jvm/j2sdk1.6-oracle \
   /usr/lib/jvm/j2sdk1.6-oracle/jre \
   /usr/java/jdk1.6* \
   /usr/java/jre1.6* \
   /usr/java/jdk1.7* \
   /usr/java/jre1.7* \
   /usr/lib/jvm/j2sdk1.7-oracle \
   /usr/lib/jvm/j2sdk1.7-oracle/jre \
   /Library/Java/Home \
   /usr/java/default \
   /usr/lib/jvm/default-java \
   /usr/lib/jvm/java-openjdk \
   /usr/lib/jvm/jre-openjdk \
   /usr/lib/jvm/java-1.7.0-openjdk* \
   /usr/lib/jvm/java-7-openjdk* \
   /usr/lib/jvm/java-7-oracle* \
   /usr/lib/jvm/java-1.6.0-openjdk \
   /usr/lib/jvm/java-1.6.0-openjdk-* \
   /usr/lib/jvm/jre-1.6.0-openjdk* ; do