Beehive
  1. Beehive
  2. BEEHIVE-864

Add a test for registering a request based TemplatedURLFormatter with the URLRewriterService API

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: V1Beta, v1m1
    • Fix Version/s: 1.0
    • Component/s: NetUI
    • Labels:
      None

      Description

      To improve on the test coverage for the URLRewriterService and the use of templates, I've created
      a patch for the urlTemplates test webapp. The patch contains a a servlet Filter that calls the
      URLRewriterService.registerTemplatedURLFormatter() to register a custom
      TemplatedURLFormatter for a specific page flow. The formatter test does per request based
      formatting of a rewritten URL using templates from the URL template config file.

      1. j864-patch.zip
        5 kB
        Carlin Rogers

        Activity

        Hide
        Carlin Rogers added a comment -

        This patch adds new files for the new TemplatedURLFormatter testing.

        Note that the zip file also contains a gif image file that needs to be copied into place since
        svn diff does not pick up the binary files when creating a patch. The file image.gif should be
        copied to both...
        netui/test/webapps/urlTemplates/urlTemplates/formatter/image.gif
        netui/test/webapps/urlTemplates/urlTemplates/formatter/secureImage.gif

        Show
        Carlin Rogers added a comment - This patch adds new files for the new TemplatedURLFormatter testing. Note that the zip file also contains a gif image file that needs to be copied into place since svn diff does not pick up the binary files when creating a patch. The file image.gif should be copied to both... netui/test/webapps/urlTemplates/urlTemplates/formatter/image.gif netui/test/webapps/urlTemplates/urlTemplates/formatter/secureImage.gif
        Hide
        Carlin Rogers added a comment -

        Assigning to Rich to review as an additional test for V1.

        Show
        Carlin Rogers added a comment - Assigning to Rich to review as an additional test for V1.
        Hide
        Rich Feit added a comment -

        OK, this is in with revision 230971.

        Show
        Rich Feit added a comment - OK, this is in with revision 230971.
        Hide
        Alejandro Ramirez added a comment -

        please verify

        Show
        Alejandro Ramirez added a comment - please verify
        Hide
        Nathan Jantz added a comment -

        Verified in svn 239233. I verified that the test was implemented in urlTemplates and ran the test manually. (http://localhost:8080/urlTemplates/formatter/index.jsp). Observed that all urls were rewritten on that request only with the newly formatted URL inserting "prefix" string. such as:
        http://beehive.apache.org:8080/prefix/urlTemplates/formatter/begin.do?URLTEMPLATE=action&"

        This verified the test hit TemplatedURLFormatter.

        Closing issue.

        Show
        Nathan Jantz added a comment - Verified in svn 239233. I verified that the test was implemented in urlTemplates and ran the test manually. ( http://localhost:8080/urlTemplates/formatter/index.jsp ). Observed that all urls were rewritten on that request only with the newly formatted URL inserting "prefix" string. such as: http://beehive.apache.org:8080/prefix/urlTemplates/formatter/begin.do?URLTEMPLATE=action& " This verified the test hit TemplatedURLFormatter. Closing issue.

          People

          • Assignee:
            Nathan Jantz
            Reporter:
            Carlin Rogers
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development