Beehive
  1. Beehive
  2. BEEHIVE-338

The treeAttribute tag is not applying attributes correctly to the treeItems

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1m1
    • Fix Version/s: v1m1
    • Component/s: NetUI
    • Labels:
      None

      Description

      It appears that all of the attribute tests are broken. The attributes don't seem to be applied to the nodes at all at the moment. Not sure when the was broken, it did work at one point.

        Activity

        Hide
        Daryl Olander added a comment -

        A while ago I simplified the HTML output for the tree. At one point we output the label as <span>label</span>. The span was removed and the label simply appears next to the icon image.

        The TreeHtmlAttribute supported setting attributes on the <span>
        through the onLabelLink attribute. In addition, the onIconLink was used to set HTML attributes on the anchor used for selection.

        All of the attribute test actually set that attribute which is the reason it looked like we were not actually setting attributes correctly.

        In this fix, removed the onLabelLink from TreeHtmlAttribute and also renamed the onIconLink to onSelectionLink.

        I also updated all of the tests so that they use onSelectionLink now and verified the test results.

        Show
        Daryl Olander added a comment - A while ago I simplified the HTML output for the tree. At one point we output the label as <span>label</span>. The span was removed and the label simply appears next to the icon image. The TreeHtmlAttribute supported setting attributes on the <span> through the onLabelLink attribute. In addition, the onIconLink was used to set HTML attributes on the anchor used for selection. All of the attribute test actually set that attribute which is the reason it looked like we were not actually setting attributes correctly. In this fix, removed the onLabelLink from TreeHtmlAttribute and also renamed the onIconLink to onSelectionLink. I also updated all of the tests so that they use onSelectionLink now and verified the test results.
        Hide
        Krista Baker added a comment -

        Verified that the treeHtmlAttributes are properly applied to the link, icon, and div when the appropriate attributes are set to true on static and dynamic trees.

        Show
        Krista Baker added a comment - Verified that the treeHtmlAttributes are properly applied to the link, icon, and div when the appropriate attributes are set to true on static and dynamic trees.

          People

          • Assignee:
            Krista Baker
            Reporter:
            Daryl Olander
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development