Beehive
  1. Beehive
  2. BEEHIVE-1176

Improve NetUI AP perf by reducing the number of calls to PackageDeclaration.getPackage()

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.1, 1.0.2
    • Fix Version/s: V.Next
    • Component/s: NetUI
    • Labels:
      None

      Description

      The NetUI annotation processors make calls to TypeDeclaration.getPackage() in various places. This is not always a simple and fast call, In some APT cases, to create a PackageDeclaration involves bringing the entire
      package into memory, which involves reading jar files. With some first passes of profiling I noticed we were spending lots of time in calls to org.apache.beehive.netui.compiler.typesystem.impl.declaration.TypeDeclarationImpl.getPackage(). In most cases we just use the PackageDeclaration to get the package name. This could be avoided by just getting the fully qualified name of the TypeDeclaration and stripping off the class name portion to get the package name.

        Activity

        Carlin Rogers created issue -
        Carlin Rogers made changes -
        Field Original Value New Value
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]

          People

          • Assignee:
            Carlin Rogers
            Reporter:
            Carlin Rogers
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development