Beehive
  1. Beehive
  2. BEEHIVE-1043

Relax the forward action not found from an error to a warning.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.0.1
    • Component/s: NetUI
    • Labels:
      None

      Description

      A forward that references a non-existent action using the action attribute is currently an error while referencing a
      non-existent action or page with the path attribute results in a compiler warning. Note that action="..." does not support referencing an action name in a Struts module. So rather than report an error, just report a warning.

      After a brief discussion on the dev list, I think we're in agreement that it's OK to relax this to a warning

      See the discussion in the archive...
      http://mail-archives.apache.org/mod_mbox/beehive-dev/200601.mbox/%3cba6911de0601130801y5b949986x1f0c0f3de8e67ba9@mail.gmail.com%3e

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        3d 21h 33m 1 Carlin Rogers 18/Jan/06 03:06
        Alejandro Ramirez made changes -
        Assignee Carlin Rogers [ crogers ] Julie Zhuo [ jzhuo ]
        Carlin Rogers made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Carlin Rogers added a comment -

        This has been fixed with svn revision 369852,...
        http://svn.apache.org/viewcvs?rev=369852&view=rev

        To test this, create a page flow and add an action to the page flow Controller such that the Jpf.Forward annotation of the action has an action attribute (rather than path) with the value being a bogus, non-existant action name. Something like the following.

        @Jpf.Action(
        forwards =

        { @Jpf.Forward( name = "success", action = "aBogusAction") }

        )
        public Forward testAction()

        { return new Forward("success"); }

        Before this change, the compiler would report an error. Now, the compiler will report only a warning.

        Show
        Carlin Rogers added a comment - This has been fixed with svn revision 369852,... http://svn.apache.org/viewcvs?rev=369852&view=rev To test this, create a page flow and add an action to the page flow Controller such that the Jpf.Forward annotation of the action has an action attribute (rather than path) with the value being a bogus, non-existant action name. Something like the following. @Jpf.Action( forwards = { @Jpf.Forward( name = "success", action = "aBogusAction") } ) public Forward testAction() { return new Forward("success"); } Before this change, the compiler would report an error. Now, the compiler will report only a warning.
        Carlin Rogers made changes -
        Fix Version/s 1.0.1 [ 12310717 ]
        Affects Version/s V1 [ 12310123 ]
        Carlin Rogers made changes -
        Field Original Value New Value
        Summary Relax the Relax the forward action not found from an error to a warning.
        Hide
        Carlin Rogers added a comment -

        oops, sorry about the bogus subject on the initial submit/create of the bug.

        Show
        Carlin Rogers added a comment - oops, sorry about the bogus subject on the initial submit/create of the bug.
        Carlin Rogers created issue -

          People

          • Assignee:
            Julie Zhuo
            Reporter:
            Carlin Rogers
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development