[BEANUTILS-564] Some tests fail on Java 21 and 22-ea

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Assignee: Unassigned
• Reporter: Gary D. Gregory
• Created: 09/Dec/23 15:57
• Updated: 16/Jan/24 21:36
• Resolved: 16/Jan/24 21:36

Description

Some tests fail on Java 21, for example:

[ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.012 s <<< FAILURE! -- in org.apache.commons.beanutils2.sql.converters.SqlTimeConverterTestCase
[ERROR] org.apache.commons.beanutils2.sql.converters.SqlTimeConverterTestCase.testLocale -- Time elapsed: 0.006 s <<< FAILURE!
junit.framework.AssertionFailedError: Converting 'java.lang.String' value '3:06 pm' threw org.apache.commons.beanutils2.ConversionException: Error converting 'String' to 'java.sql.Time' using pattern 'h:mm a', localized pattern 'h:mm a', errorIndex 4, calendar type GregorianCalendar, this org.apache.commons.beanutils2.sql.converters.SqlTimeConverter[UseDefault=false, UseLocaleFormat=true]
	at junit.framework.Assert.fail(Assert.java:57)
	at junit.framework.TestCase.fail(TestCase.java:223)
	at org.apache.commons.beanutils2.converters.AbstractDateConverterTest.validConversion(AbstractDateConverterTest.java:572)
	at org.apache.commons.beanutils2.sql.converters.SqlTimeConverterTestCase.testLocale(SqlTimeConverterTestCase.java:118)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at junit.framework.TestCase.runTest(TestCase.java:177)
	at junit.framework.TestCase.runBare(TestCase.java:142)
	at junit.framework.TestResult$1.protect(TestResult.java:122)
	at junit.framework.TestResult.runProtected(TestResult.java:142)
	at junit.framework.TestResult.run(TestResult.java:125)
	at junit.framework.TestCase.run(TestCase.java:130)
	at junit.framework.TestSuite.runTest(TestSuite.java:241)
	at junit.framework.TestSuite.run(TestSuite.java:236)

[INFO] Running org.apache.commons.beanutils2.sql.converters.SqlTimestampConverterTestCase
[ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.008 s <<< FAILURE! -- in org.apache.commons.beanutils2.sql.converters.SqlTimestampConverterTestCase
[ERROR] org.apache.commons.beanutils2.sql.converters.SqlTimestampConverterTestCase.testLocale -- Time elapsed: 0.002 s <<< FAILURE!
junit.framework.AssertionFailedError: Converting 'java.lang.String' value '3/21/06, 3:06 PM' threw org.apache.commons.beanutils2.ConversionException: Error converting 'String' to 'java.sql.Timestamp' using pattern 'M/d/yy, h:mm a', localized pattern 'M/d/yy, h:mm a', errorIndex 13, calendar type GregorianCalendar, this org.apache.commons.beanutils2.sql.converters.SqlTimestampConverter[UseDefault=false, UseLocaleFormat=true]
	at junit.framework.Assert.fail(Assert.java:57)
	at junit.framework.TestCase.fail(TestCase.java:223)
	at org.apache.commons.beanutils2.converters.AbstractDateConverterTest.validConversion(AbstractDateConverterTest.java:572)
	at org.apache.commons.beanutils2.sql.converters.SqlTimestampConverterTestCase.testLocale(SqlTimestampConverterTestCase.java:138)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at junit.framework.TestCase.runTest(TestCase.java:177)
	at junit.framework.TestCase.runBare(TestCase.java:142)
	at junit.framework.TestResult$1.protect(TestResult.java:122)
	at junit.framework.TestResult.runProtected(TestResult.java:142)
	at junit.framework.TestResult.run(TestResult.java:125)
	at junit.framework.TestCase.run(TestCase.java:130)
	at junit.framework.TestSuite.runTest(TestSuite.java:241)
	at junit.framework.TestSuite.run(TestSuite.java:236)

The failures appear similar on Java 22-ea.

CI builds are here: https://github.com/apache/commons-beanutils/actions running on Java 8, 11, 17, 21, and 22-ea.