[BEANUTILS-533] If expression contains ")", DefaultResolver #getKey return wrong value

• Type: Bug
• Status: Open
• Priority: Blocker
• Resolution: Unresolved
• Affects Version/s: 1.7.0, 1.8.0, 1.9.0, 1.9.3
• Component/s: Bean / Property Utils
• Assignee: Unassigned
• Reporter: Maxime Garenne
• Created: 26/Feb/20 14:16
• Updated: 21/Jun/23 14:16

Description

Context

I use BeanUtils to return a map that contain properties.

I had a failure in my code because this property causes a fail in the BeanUtils "getMappedProperty" method :

test(myvalue(ineedthisparenthis))

Explanation

In DefaultResolver #getKey(String expression), if the expression contains a ")", the returned value is incorrect because the algorithm stops at the first ")" character (#indefOf is used).

In my example, the method now returns : "myvalue(ineedthisparenthis". It should be "myvalue(ineedthisparenthis) with proprerty name = "test".

Instead of using :

final int end = expression.indexOf(MAPPED_END, i);

It would be better to just check if the last character of "expression" is a ")" and then substring between "i+1" and last character index.

Then my example would not fail. 

 

This occurs in version 1.7.

I checked in upper versions, the method is different but still wrong because the method indexOf is still used (taking again the first ")" found). 

 # escape # parenthesis # bracket # DefaultResolver # getKey # expression

 

Issue Links

• is related to: BEANUTILS-104 [beanutils]special characters in mapped property keys are parsed incorrectly
• links to: [BEANUTILS-533] - If expression contains ")", DefaultResolver #getKey #65
• links to: GitHub Pull Request #65