[BEANUTILS-379] Remove copied Collections classes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.3
• Fix Version/s: 1.9.5
• Component/s: Bean / Property Utils
• Assignee: Niall Pemberton
• Reporter: Niall Pemberton
• Created: 02/Sep/10 16:26
• Updated: 14/Apr/24 12:49
• Resolved: 10/Sep/10 15:49

Description

In BeanUtils 1.7 four classes were copied from Commons Collections with the aim of removing that dependency:

• ArrayStack
• Buffer
• BufferUnderflowException
• FastHashMap

However there are other classes within BeanUtils that depend on Commons Collections (e.g. BeanMap) - so three flavours of jars were created:

• commons-beanutils.jar (all classes)
• commons-beanutils-core.jar (core beantils which doesn't require Commons Collections)
• commons-beanutils-bean-collections.jar (classes dependant on Commons Collections)

This situation is a bit of a mess an is causing issues such as BEANUTILS-378

I suggest the following action is taken in the next 1.x BeanUtils release:

• remove the copied Commons Collections classes
• add Commons Collections as a dependency
• Only produce the one commons-beanutils.jar

Removing the dependency on the four collections classes is more difficult as some of them are in BeanUtils API

Issue Links

• is depended upon by: BEANUTILS-378 BeanMap does not work in osgi class not found org.apache.commons.collections.Transformer
• is related to: BEANUTILS-398 CLONE - The three jars contain wrong classes
• relates to: BEANUTILS-418 OSGi Manifest for BeanUtils should optionally import commons-collections