Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-9797

license_script.sh calls pip install/uninstall in local env

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • P2
    • Resolution: Fixed
    • None
    • 2.21.0
    • build-system
    • None

    Description

      File is: https://github.com/apache/beam/blob/master/sdks/java/container/license_scripts/license_script.sh

      The problem is with the code that does pip install and uninstall.
      1. It is not okay to modify the local environment.
      2. Running this script in parallel with itself (on Jenkins) has a chance to cause a race.

      The solution is to use a tox environment to run this script in. Tox will take care of creating a virtualenv with the required dependencies.

      Attachments

        Activity

          People

            hannahjiang Hannah Jiang
            udim Udi Meiri
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 4h 50m
                4h 50m