Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-9438

warn or error when constructor runner != options runner

Details

    • Improvement
    • Status: Open
    • P3
    • Resolution: Unresolved
    • None
    • None
    • sdk-py-core
    • None

    Description

      Right now, the runner set in the Pipeline constructor silently overrides the runner set in pipeline options [1]. This can result in subtle errors, where a different runner is used than expected [2]. I can't imagine any legitimate reason anyone would want to do this, so we should error when they contradict each other, or at least warn.

      [1] https://github.com/apache/beam/blob/e20b0c213034cd438d48f4a2cb56cc902dae023f/sdks/python/apache_beam/pipeline.py#L179-L186
      [2] https://github.com/tensorflow/tfx/blob/02ead9886726cf2cebd9a3d1e1b4bbd0f2cf9d00/tfx/components/base/base_executor.py#L142-L143

      Attachments

        Activity

          People

            Unassigned Unassigned
            ibzib Kyle Weaver
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: