Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-9241

Fix inconsistent nullability mapping for Protobuf to Schema

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P2
    • Resolution: Fixed
    • Affects Version/s: 2.18.0
    • Fix Version/s: 2.20.0
    • Labels:
      None

      Description

      Fix the nullability issues with protobuf to schema mapping

      • Proto3 primitive types should be not nullable.
      • Proto2 required types should be not nullable.
      • Proto2 optional should also be not nullable as having an optional value doesn't mean it has not value. The spec states it has the optional value.
      • Arrays should be not nullable, as proto arrays always have an empty array when no value is set.
      • Maps should be not nullable, as proto maps always have an empty map when no value is set.
      • Elements in an array should be not nullable, as nulls are not allowed in an array.
      • Names and Values should be not nullable, as nulls are not allowed.
      • Rows are nullable, as messages are nullable.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alexvanboxel Alex Van Boxel
                Reporter:
                alexvanboxel Alex Van Boxel
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 40m
                  1h 40m