[BEAM-8917] javax.annotation.Nullable is missing for org.apache.beam.sdk.schemas.FieldValueTypeInformation

• Type: Improvement
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: 2.17.0
• Component/s: sdk-java-core
• Labels: Done
• Assignee: Tomo Suzuki
• Reporter: Tomo Suzuki
• Created: 09/Dec/19 03:19
• Updated: 06/Oct/20 21:55
• Resolved: 17/Dec/19 10:22

Description

This ticket is from the result of static analysis by Linkage Checker (detail)

Example Project

Example project to produce an issue: https://github.com/suztomo/beam-java-sdk-missing-nullable .

I think the Maven artifact org.apache.beam:beam-sdks-java-core, which contains org.apache.beam.sdk.schemas.FieldValueTypeInformation, should declare the dependency to com.google.code.findbugs:jsr305.

Why there's no problem in compilation and tests of sdks/java/core?

The compilation succeeds because the Nullable annotation is in the transitive dependency of compileOnly spotbugs-annotations dependency:

compileOnly - Compile only dependencies for source set 'main'.
...
+--- com.github.spotbugs:spotbugs-annotations:3.1.12
|    \--- com.google.code.findbugs:jsr305:3.0.2
...

The tests succeed because the Nullable annotation is in the transitive dependency of guava-testlib.

testRuntime - Runtime dependencies for source set 'test' (deprecated, use 'testRuntimeOnly' instead).
...
+--- com.google.guava:guava-testlib:20.0
|    +--- com.google.code.findbugs:jsr305:1.3.9

Issue Links

• is related to: BEAM-8858 Missing dependencies in SQL module pom
• links to: GitHub Pull Request #10324
• links to: GitHub Pull Request #10370
• links to: GitHub Pull Request #10371