[BEAM-8911] Upgrade Guava to 25

• Type: Improvement
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: Not applicable
• Component/s: build-system
• Assignee: Tomo Suzuki
• Reporter: Tomo Suzuki
• Created: 06/Dec/19 17:58
• Updated: 12/Jan/21 22:29
• Resolved: 24/Jan/20 20:38

Description

Now BEAM-8822 Hadoop client version 2.8.5 from 2.7 is merged. It's time to upgrade Guava.

New Guava version: 25.1-jre

CharMatcher.DIGIT, used by org.apache.cassandra.io.sstable.format.SSTableFormat, is removed since Guava 26.0. 25.1 is the latest version:

https://guava.dev/releases/25.1-jre/api/docs/com/google/common/base/CharMatcher.html
https://guava.dev/releases/26.0-jre/api/docs/com/google/common/base/CharMatcher.html

Guava has 2 variations "-jre" for Java8 (stream/lambda support) and "-android" for Java7. Gcsio:1.9.16, which Beam has not have in dependency tree yet, needs ImmutableSet.toImmutableSet() which is available in Guava "-jre".

https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1028#issuecomment-557680928

What about upgrading Cassandra-all?

The latest cassandra-all release is "4.0-alpha2", which is still alpha. This version depends on guava 27.0-jre (link).

Non-alpha version is 3.11.5 https://search.maven.org/artifact/org.apache.cassandra/cassandra-all/3.11.5/jar, which still relies on Guava 18 and it still has reference to DIGIT:

suztomo@suxtomo24:~/grpc-java$ javap -v -cp ~/Downloads/cassandra-all-3.11.5.jar 'org.apache.cassandra.io.sstable.format.SSTableFormat$Type' |grep DIGIT
    #9 = Fieldref           #79.#80       // com/google/common/base/CharMatcher.DIGIT:Lcom/google/common/base/CharMatcher;
   #80 = NameAndType        #110:#111     // DIGIT:Lcom/google/common/base/CharMatcher;
  #110 = Utf8               DIGIT

Guava 19 has digit() method. Not Guava 18.

Issue Links

• links to: GitHub Pull Request #10318