Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-887

Make FileBasedSink.getWriterResultCoder abstract

Details

    Description

      FileBasedSink has this function:

          /**
            * Returns a coder for the writer result type.
            */
          public Coder<WriteT> getWriterResultCoder() {
            return null;
          }
      

      It returns null by default, but in practice if this happens then building the pipeline will crash with a NullPointerException. Now that we can make backward-incompatible changes, just make it abstract and force implementations to add this method. (All existing implementations override it already.)

      Attachments

        Activity

          People

            kenn Kenneth Knowles
            dhalperi Dan Halperin
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: