[BEAM-8414] Cleanup Python codebase to enable some of the excluded Python lint checks.

• Type: Improvement
• Status: Resolved
• Priority: P3
• Resolution: Fixed
• Fix Version/s: Not applicable
• Component/s: sdk-py-core
• Labels: beginner easy easy-fix easyfix newbie stale-assigned starter
• Assignee: Stephen O'Kennedy
• Reporter: Valentyn Tymofieiev
• Created: 16/Oct/19 18:51
• Updated: 24/Jul/20 19:55
• Resolved: 02/Jun/20 18:21

Description

https://github.com/apache/beam/pull/9725 upgraded lint checker, however Beam codebase is not fully compliant with some of the checks new linter supports, so we excluded such checks. We would like to have some checks permanently excluded (see discussion on the PR), however we would like to re-enable the following checks:

consider-using-set-comprehension
chained-comparison
consider-using-sys-exit

To reenable these checks, we should:
1) remove them from disabled checks in .pylintrc [1] https://github.com/apache/beam/blob/master/sdks/python/.pylintrc and
2) cleanup the codebase to make it compliant.

[1] https://github.com/apache/beam/blob/3330069291d8168c56c77acfef84c2566af05ec6/sdks/python/.pylintrc#L81

Issue Links

• links to: GitHub Pull Request #11523