[BEAM-8175] Setting java keystore overrides basic auth in ElasticsearchIO connection configuration

• Type: Bug
• Status: Open
• Priority: P3
• Resolution: Unresolved
• Affects Version/s: 2.15.0
• Component/s: io-java-elasticsearch
• Assignee: Unassigned
• Reporter: Hemant Y Bhoyar
• Created: 07/Sep/19 09:55
• Updated: 16/Jun/20 17:25

Description

While creating the rest client in ElasticsearchIO, the httpClientConfigCallback is overridden by the step to set the key store.

Making it not possible to use a custom key store with basic auth.

if (getUsername() != null) {
  final CredentialsProvider credentialsProvider = new BasicCredentialsProvider();
  credentialsProvider.setCredentials(
      AuthScope.ANY, new UsernamePasswordCredentials(getUsername(), getPassword()));
  restClientBuilder.setHttpClientConfigCallback(
      httpAsyncClientBuilder -> httpAsyncClientBuilder.setDefaultCredentialsProvider(credentialsProvider));
}
if (getKeystorePath() != null && !getKeystorePath().isEmpty()) {
  try {
    KeyStore keyStore = KeyStore.getInstance("jks");
    try (InputStream is = new FileInputStream(new File(getKeystorePath()))) {
      String keystorePassword = getKeystorePassword();
      keyStore.load(is, (keystorePassword == null) ? null : keystorePassword.toCharArray());
    }
    final SSLContext sslContext =
        SSLContexts.custom()
            .loadTrustMaterial(keyStore, new TrustSelfSignedStrategy())
            .build();
    final SSLIOSessionStrategy sessionStrategy = new SSLIOSessionStrategy(sslContext);
    restClientBuilder.setHttpClientConfigCallback(
        httpClientBuilder -> httpClientBuilder.setSSLContext(sslContext).setSSLStrategy(sessionStrategy));
  } catch (Exception e) {
    throw new IOException("Can't load the client certificate from the keystore", e);
  }
}