Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-8156

Finish migration to standard Python typing

Details

    • Improvement
    • Status: Open
    • P3
    • Resolution: Unresolved
    • None
    • None
    • sdk-py-core
    • None

    Description

      We should migrate all Python uses of types to the standard typing module, and make the typehints.* ones aliases of the Python ones. 

       

      There are three places where we use custom typehints behavior: 

      (1) is_compatible_with

      (2) bind_type_variables/match_type_variables

      (3) trivial type inference. 

       

      I would propose that each of these be adapted to a (internal) public interface that accepts and returns standard typing types, and internally converts to our (nowhere else exposed) typehints types, performs the logic, and converts back. Each of these in turn can then be updated, as needed and orthogonally, to operate on the typing types natively (possibly via deference to a third-party library). 

       

      I think coder inference could be easily adopted to use typing types directly, but it may be a fourth place where we do internal conversion first. Another gotcha is special care may need to be taken if we ever need to pickle these types (which IIRC may have issues). 

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              robertwb Robert Bradshaw
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - 504h
                  504h
                  Remaining:
                  Remaining Estimate - 502h 20m
                  502h 20m
                  Logged:
                  Remaining Estimate - 502h 20m
                  1h 40m